Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Apply schema transformer to AdditionalProperties #59730

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[release/9.0] Apply schema transformer to AdditionalProperties #59730

merged 1 commit into from
Jan 10, 2025
+15 −2

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 6, 2025 •
edited by captainsafia
Loading

Backport of #59699 to release/9.0

/cc @captainsafia @JTeeuwissen

Description

This pull request invokes the schema transformer to the AdditionalProperties field within the JSON schema.

Fixes #59616

Customer Impact

This change is necessary to ensure the schema transformer correctly applies to AdditionalProperties, a sub-field within the JSON schema.

While there are workarounds for this issue, the workarounds require the user to implement an extensive amount of custom code in order to properly recurse into an AdditionalProperties subschemas for a given type.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Low risk because:

  • Change is localized to Microsoft.AspNetCore.OpenApi package
  • Change is additive and doesn't change existing behavior

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@github-actions github-actions bot requested review from captainsafia and a team as code owners January 6, 2025 14:45
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 6, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.x milestone Jan 6, 2025
@captainsafia captainsafia added Servicing-consider Shiproom approval is required for the issue feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc labels Jan 6, 2025
@captainsafia
Copy link
Member

Approved via email.

@captainsafia captainsafia added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jan 10, 2025
@wtgodbe wtgodbe merged commit 6238e5d into release/9.0 Jan 10, 2025
25 checks passed
@wtgodbe wtgodbe deleted the backport/pr-59699-to-release/9.0 branch January 10, 2025 21:24
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 9.0.x, 9.0.2 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
9.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@captainsafia @wtgodbe @JTeeuwissen