Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .AutoVerify() call #59781

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Remove .AutoVerify() call #59781

merged 1 commit into from
Jan 10, 2025

Conversation

captainsafia
Copy link
Member

No description provided.

@captainsafia captainsafia requested a review from a team as a code owner January 8, 2025 22:01
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 8, 2025
@captainsafia captainsafia enabled auto-merge (squash) January 8, 2025 22:01
@BrennanConroy
Copy link
Member

Explain? You just added this 303b53f
Does something else need to be done to cover "check for top-level schemas"?

@captainsafia
Copy link
Member Author

Explain? You just added this 303b53f Does something else need to be done to cover "check for top-level schemas"?

Nope.

With the snapshot tool, if you run the tests and the generated OpenAPI document is different from the *.verified.txt file that is committed in source it will generate a new *.received.txt file that contains the actual results. The diff between the two is what is different.

AutoVerify indicates that the snapshot testing tool should accept the new contents and update the existing *.verified.txt files automatically. I turn this on locally in dev mode because I find that it can be easier sometimes to diff against the *verified.txt files that already tracked by git. Especially if I don't expect there to be any changes between the two.

However, the AutoVerify call shouldn't be committed into the tests.

We shouldn't need to make any changes here since the original PR contained no deltas in the *.verfieid.txt files. If something did go wrong, we can expect the CI runs here to fail.

@captainsafia captainsafia merged commit 9cbc884 into main Jan 10, 2025
27 checks passed
@captainsafia captainsafia deleted the safia/rm-autoverify branch January 10, 2025 19:24
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants