Enable NuGet Audit in the VMR orchestrator, normalize and update dependencies #45830
+27
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndencies - We recently were contacted because the VMR orchestrator was restoring vulnerable assets. To prevent this going forward, enable NuGetAudit which currently is disabled in the product explicitly. - Update dependencies to avoid transitive vulnerabilities - Remove direct Reference items that resolved assemblies from within the .NET SDK in favor of PackageReference items with the IncludeAssets="compile" metadata. This indicates that the packages are only used for targeting and not at run time. With that, remove hacks (NoWarn ResolveAssemblyReference warnings) in Microsoft.DotNet.Tests that were necessary because of the mix of Reference and PackageReference dependencies.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
This was referenced Jan 9, 2025
mmitche
approved these changes
Jan 9, 2025
This was referenced Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were recently contacted because the VMR orchestrator was restoring vulnerable assets. To prevent this going forward, enable NuGetAudit which is currently disabled in the product.
Update dependencies to avoid transitive vulnerabilities (this requires an SBRP update)
Remove direct Reference items that resolved assemblies from within the .NET SDK in favor of PackageReference items with the IncludeAssets="compile" metadata. This indicates that the packages are only used for targeting and not at run time. With that, remove hacks (NoWarn ResolveAssemblyReference warnings) in Microsoft.DotNet.Tests that were necessary because of the mix of Reference and PackageReference dependencies.