Add linux-riscv64 in ILCompilerSupportedRids #45852
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
Updating with latest main as we had a build break that just got fixed with 6b3a36d |
|
/ba is showing a new failure in TemplateEngine, which is unrelated to the change. |
| @@ -387,7 +387,11 @@ | |||
|
|
|||
| <!-- The subset of ILCompiler target RIDs that are officially supported. Should be a subset of | |||
There was a problem hiding this comment.
This comment says that this list should be a subset of ILCompilerRIDs.props, but it is not the case. Does the comment or ILCompilerRIDs.props need updating?
There was a problem hiding this comment.
Yes it's not strictly a subset. We include the official RIDs then the current OutputRID, which covers a set that is not a superset of all the allowed RIDs. I will update the comment.
| @@ -387,7 +387,11 @@ | |||
|
|
|||
| <!-- The subset of ILCompiler target RIDs that are officially supported. Should be a subset of | |||
| https://github.com/dotnet/runtime/blob/main/src/installer/pkg/projects/Microsoft.DotNet.ILCompiler/ILCompilerRIDs.props --> | |||
| <ILCompilerSupportedRids Include="@(Net90ILCompilerSupportedRids)" /> | |||
| <ILCompilerSupportedRids Include=" | |||
There was a problem hiding this comment.
All other lists have a version number. Should this one have a version number as well?
There was a problem hiding this comment.
this is fine. we need one item that represents the "current" list, this is that.
There was a problem hiding this comment.
Should other community supported architectures be moved to the "current" list?
There was a problem hiding this comment.
Next version properties are added around preview 1 I think. Currently, net10 is using version less properties.
Should other community supported architectures be moved to the "current" list?
It is the inheritance chain. For each component, the RID is listed once under the .NET version where its support was enabled. The next version property just inherits the previous one. LoongArch was handled last year https://github.com/dotnet/installer/pull/19469/files.
There was a problem hiding this comment.
I think we add the next version properties when we do branching, i.e. for net11
Related to dotnet/runtime#110688.
cc @dotnet/samsung, @akoeplinger, @jkoritzinsky