Support --solution option in dotnet test #45859

mariam-abdulla · 2025-01-10T09:52:22Z

No description provided.

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

…erties' of https://github.com/dotnet/sdk into dev/mabdullah/use-msbuild-apis-to-retrieve-project-properties

…ations is set to false

…ution files

…n files

…roject-properties

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

…roject-properties

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

…erties' of https://github.com/dotnet/sdk into dev/mabdullah/use-msbuild-apis-to-retrieve-project-properties

…roject-properties

…erties' of https://github.com/dotnet/sdk into dev/mabdullah/use-msbuild-apis-to-retrieve-project-properties

Copilot

Copilot reviewed 9 out of 24 changed files in this pull request and generated 1 comment.

Files not reviewed (15)

src/Cli/dotnet/commands/dotnet-test/LocalizableStrings.resx: Language not supported
src/Cli/dotnet/commands/dotnet-test/xlf/LocalizableStrings.cs.xlf: Language not supported
src/Cli/dotnet/commands/dotnet-test/xlf/LocalizableStrings.de.xlf: Language not supported
src/Cli/dotnet/commands/dotnet-test/xlf/LocalizableStrings.es.xlf: Language not supported
src/Cli/dotnet/commands/dotnet-test/xlf/LocalizableStrings.fr.xlf: Language not supported
src/Cli/dotnet/commands/dotnet-test/xlf/LocalizableStrings.it.xlf: Language not supported
src/Cli/dotnet/commands/dotnet-test/xlf/LocalizableStrings.ja.xlf: Language not supported
src/Cli/dotnet/commands/dotnet-test/xlf/LocalizableStrings.ko.xlf: Language not supported
src/Cli/dotnet/commands/dotnet-test/xlf/LocalizableStrings.pl.xlf: Language not supported
src/Cli/dotnet/commands/dotnet-test/xlf/LocalizableStrings.pt-BR.xlf: Language not supported
src/Cli/dotnet/commands/dotnet-test/BuiltInOptions.cs: Evaluated as low risk
src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.Help.cs: Evaluated as low risk
src/Cli/dotnet/commands/dotnet-test/TestingPlatformOptions.cs: Evaluated as low risk
src/Cli/dotnet/commands/dotnet-test/TestCommandParser.cs: Evaluated as low risk
src/Cli/dotnet/commands/dotnet-test/TestApplication.cs: Evaluated as low risk

Comments suppressed due to low confidence (3)

src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs:25

Changing the Run method from async Task to int removes the ability to await asynchronous operations, which could lead to unhandled asynchronous operations and unexpected behavior.

public int Run(ParseResult parseResult)

src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs:81

[nitpick] The method GetProjectFilePaths is defined twice in the same file. Consider renaming one of the methods to avoid confusion.

private static string[] GetProjectFilePaths(string directory)

src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs:24

The new behavior introduced by the --solution option should be covered by tests to ensure it works as expected.

var possibleSolutionPaths = GetSolutionFilePaths(directory);

src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs

Evangelink · 2025-01-10T10:53:13Z

src/Cli/dotnet/commands/dotnet-test/LocalizableStrings.resx

@@ -187,6 +187,9 @@
  <data name="CmdProjectDescription" xml:space="preserve">
    <value>Defines the path of the project file to run (folder name or full path). If not specified, it defaults to the current directory.</value>
  </data>
+  <data name="CmdSolutionDescription" xml:space="preserve">
+    <value>Defines the path of the solution file to run. If not specified, it defaults to the current directory.</value>


Do you mean if --solution is not provided or if no value is passed to --solution?

If --solution is not provided.

Evangelink · 2025-01-10T10:57:45Z

src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs

+                return false;
+            }
+
+            if (!File.Exists(filePath))


@baronfel do you have some helper around filesystem for mocking and more or is it fine to use this check directly?

src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs

src/Cli/dotnet/commands/dotnet-test/TestApplication.cs

src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs

ViktorHofer · 2025-01-10T11:04:37Z

Updating with latest main as we had a build break that just got fixed with 6b3a36d

…net-test

…https://github.com/dotnet/sdk into dev/mabdullah/support-solution-option-in-dotnet-test

mariam-abdulla and others added 30 commits January 3, 2025 13:34

Use msbuild APIs to load projects

e9c2a23

Add space

e7bcc8a

Fix formatting

8d747c7

Add comments

2b02833

Update src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs

f4cce4e

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

Replace 0 and 1 with constants

f078060

Merge branch 'dev/mabdullah/use-msbuild-apis-to-retrieve-project-prop…

4c9add2

…erties' of https://github.com/dotnet/sdk into dev/mabdullah/use-msbuild-apis-to-retrieve-project-properties

Return from InitializeTestApplications() if _areTestingPlatformApplic…

771c1f1

…ations is set to false

Update method name

def3cb8

Use aggregator overload in ProcessProjectsInParallel()

3b75ca8

Apply some comments

8e3b723

Remove ?

b7b79ef

Update GetSolutionFilePaths

5349e6c

Use Microsoft.VisualStudio.SolutionPersistence namespace to parse sol…

cbc3389

…ution files

Add GetSlnFileFullPath and GetProjectFileFullPath methods in Extensio…

9284893

…n files

Refactor

6b42f48

Update ParseSolution to use GetSerializerByMoniker

51c7424

Merge branch 'main' into dev/mabdullah/use-msbuild-apis-to-retrieve-p…

3855845

…roject-properties

Update src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs

082f260

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

Update src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs

ae87351

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

Update src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs

3e26cd3

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

Update src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs

31593b0

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

Update src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs

f781164

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

Merge branch 'main' into dev/mabdullah/use-msbuild-apis-to-retrieve-p…

7e359d1

…roject-properties

Update src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs

3c3d56b

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

Apply comments

55d247d

merge

d3b11c5

Update src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs

41323d4

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>

Use Lock

a774524

Merge branch 'dev/mabdullah/use-msbuild-apis-to-retrieve-project-prop…

9d17be2

…erties' of https://github.com/dotnet/sdk into dev/mabdullah/use-msbuild-apis-to-retrieve-project-properties

mariam-abdulla and others added 8 commits January 8, 2025 16:56

Update -bl logic

3f66a69

Merge branch 'main' into dev/mabdullah/use-msbuild-apis-to-retrieve-p…

97b5ae9

…roject-properties

Remove unused var

4f2b769

Merge branch 'dev/mabdullah/use-msbuild-apis-to-retrieve-project-prop…

6504a67

…erties' of https://github.com/dotnet/sdk into dev/mabdullah/use-msbuild-apis-to-retrieve-project-properties

Support --solution

c3dc4f2

merge

d96f016

refactor code

517c20a

Fix bug

5d05184

mariam-abdulla requested a review from a team as a code owner January 10, 2025 09:52

dotnet-issue-labeler bot added Area-DotNet Test untriaged Request triage from a team member labels Jan 10, 2025

merge

2341d1a

mariam-abdulla requested review from Evangelink and Copilot January 10, 2025 10:08

Copilot AI reviewed Jan 10, 2025

View reviewed changes

src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs Outdated Show resolved Hide resolved

mariam-abdulla added 2 commits January 10, 2025 11:13

Remove @

3bf45f4

Fixes

223b072

Evangelink reviewed Jan 10, 2025

View reviewed changes

ViktorHofer and others added 5 commits January 10, 2025 12:04

Merge branch 'main' into dev/mabdullah/support-solution-option-in-dot…

542560a

…net-test

Apply comments

efa4fb4

Merge branch 'dev/mabdullah/support-solution-option-in-dotnet-test' of …

6765a26

…https://github.com/dotnet/sdk into dev/mabdullah/support-solution-option-in-dotnet-test

Apply comments

a36f471

remove unused vars

47bced1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support --solution option in dotnet test #45859

Support --solution option in dotnet test #45859

mariam-abdulla commented Jan 10, 2025

Copilot AI left a comment

Evangelink Jan 10, 2025

mariam-abdulla Jan 10, 2025

Evangelink Jan 10, 2025

ViktorHofer commented Jan 10, 2025

Support --solution option in dotnet test #45859

Are you sure you want to change the base?

Support --solution option in dotnet test #45859

Conversation

mariam-abdulla commented Jan 10, 2025

Copilot AI left a comment

Choose a reason for hiding this comment

Evangelink Jan 10, 2025

Choose a reason for hiding this comment

mariam-abdulla Jan 10, 2025

Choose a reason for hiding this comment

Evangelink Jan 10, 2025

Choose a reason for hiding this comment

ViktorHofer commented Jan 10, 2025