Remove dependency on prebuilts tarball

[mthalman]

Fixes dotnet/source-build#4715

Dependent on #45846

[mthalman]

/azp run sdk-source-build

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mthalman]

Still getting Microsoft.VisualStudio.SolutionPersistence prebuilt from SBE. This is because SBE has a transitive dependency on an older version of Microsoft.VisualStudio.SolutionPersistence through its dependency on Microsoft.Build. Since SBE is built before msbuild, it's getting Microsoft.Build from N-1. So we need another rebootstrap to get a newer version of Microsoft.Build in N-1 with its updated version of Microsoft.VisualStudio.SolutionPersistence.

[baronfel]

@mthalman is there a process thing that MSBuild/SDK need to be aware of for future updates to this library?

[mthalman]

@mthalman is there a process thing that MSBuild/SDK need to be aware of for future updates to this library?

I believe the process is in place. It's just that an automated flow didn't occur to get the updated version to msbuild's main branch. See dotnet/msbuild#11249 (comment)

[ViktorHofer]

Still getting Microsoft.VisualStudio.SolutionPersistence prebuilt from SBE. This is because SBE has a transitive dependency on an older version of Microsoft.VisualStudio.SolutionPersistence through its dependency on Microsoft.Build.

Definitely an interesting case. Sounds like these two hops will always be necessary? As an example, what will happen the next time when M.VS.SolutionPersistence gets updated in SBE?

Could the source-build infrastructure transitively upgrade the Microsoft.VisualStudio.SolutionPersistence dependency everywhere in the stack where needed, to the SBE version? Would that generally be useful for all packages produced of out of SBE?

[mthalman]

Definitely an interesting case. Sounds like these two hops will always be necessary? As an example, what will happen the next time when M.VS.SolutionPersistence gets updated in SBE?

I see this as a one-time issue with being out of sync between the repos and not something that would occur during servicing. SBE would be referencing the MSBuild version from the N-1 artifacts. Those artifacts would contain the version of SolutionPersistence that MSBuild was referencing. So there would be no prebuilt there. The rest of the build would be using the live version of SolutionPersistence produced out of SBE.

The reason we run into this now is because the N-1 artifacts do not include the older version of SolutionPersistence. That was contained in the prebuilts tarball.

[ViktorHofer]

Thanks. I don't pretend to fully understand this but I'm happy if this won't be a problem going forward.