Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx] Backport "Pin Base Image via Digest" to release/9.0.2xx #45869

Open
wants to merge 1 commit into
base: release/9.0.1xx
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 10, 2025

Backport of #45594 to release/9.0.1xx due to @tmds's request in #45856.

Fixes #45856

Description

This feature was implemented in #44461 and is being included in the 9.0.2xx band with #45594.

The feature enables pinning the base image to a specific digest. This enables to control and determine the exact version of a container image tag that was used, which is important for software supply chain (SBOMs) and reproducibility of build environments.

  • Source-built SDKs are limited to the .1xx band. Unless it gets backported, the feature isn't available for source-built SDKs until .NET 10. If we backport it in our builds, we land on the next point*.
  • The current behavior of the 9.0.1xx band is to ignore the digest rather than give an error. This makes it undetermined what digest was effectively used. It would be preferable to have the digest work across all 9.0 bands, rather than rely on the user to know the 9.0.1xx band doesn't support it (*: or know the source-built maintainers chose to backport it manually).

Customer Impact

Without this change, the second bullet point is the big sticking point - users can provide a Digest, but the tooling will not make use of the digest.

Regression?

No - this is a new feature in 9.0.2xx

Risk

Low - we have good (new) test coverage here, and this doesn't change any of the logic around consuming the base images themselves, only the selection of which base image to use.

@github-actions github-actions bot requested a review from a team as a code owner January 10, 2025 15:51
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jan 10, 2025
@baronfel baronfel changed the title [release/9.0.1xx] Backport #44461 to release/9.0.2xx [release/9.0.1xx] Backport "Pin Base Image via Digest" to release/9.0.2xx Jan 10, 2025
@baronfel baronfel added Servicing-consider Area-Containers Related to dotnet SDK containers functionality labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Containers Related to dotnet SDK containers functionality Area-Infrastructure Servicing-consider untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants