element-call - Allow the config key to template directly into config so that parameters don't need to be enumerated in chart #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers don't need to be enumerated in chart Signed-off-by: Rhea Danzey <rdanzey@element.io>
guillaumevillemont
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into issues with trying to set parameters that are new to element-call and not yet configured in this chart. To reduce the dependency on going back and forth, we can just populate the configuration directly from the Helm values instead, which will allow new options to be set without having to change the chart itself.
Signed-off-by: Rhea Danzey rdanzey@element.io