addressing code quality issues #EA-3723

europeana · Mar 4, 2024 · 158566b · 158566b
1 parent ad46bed
commit 158566b
Show file tree

Hide file tree

Showing 11 changed files with 325 additions and 328 deletions.
diff --git a/...ions/src/main/java/eu/europeana/annotation/definitions/model/impl/AbstractAnnotation.java b/...ions/src/main/java/eu/europeana/annotation/definitions/model/impl/AbstractAnnotation.java
@@ -23,7 +23,7 @@ public abstract class AbstractAnnotation implements Annotation, AnnotationView {
   private Date generated;
   private Body body;
   private Target target;
-  private String motivation;
+  protected String motivation;
   private Style styledBy;
   protected MotivationTypes motivationType;
   private Date disabled;
@@ -244,7 +244,7 @@ public MotivationTypes getMotivationType() {
   }
 
   @Override
-  public final void setMotivation(String motivation) {
+  public void setMotivation(String motivation) {
     this.motivation = motivation;
   }
 

diff --git a/...s/src/main/java/eu/europeana/annotation/definitions/model/impl/BaseCaptionAnnotation.java b/...s/src/main/java/eu/europeana/annotation/definitions/model/impl/BaseCaptionAnnotation.java
@@ -7,7 +7,7 @@ public class BaseCaptionAnnotation extends AbstractAnnotation implements Annotat
 
 	public BaseCaptionAnnotation(){
 		super();
-		setMotivation(MotivationTypes.CAPTIONING.getOaType());
+		motivation = MotivationTypes.CAPTIONING.getOaType();
 	}
 
 }
diff --git a/...rc/main/java/eu/europeana/annotation/definitions/model/impl/BaseDescribingAnnotation.java b/...rc/main/java/eu/europeana/annotation/definitions/model/impl/BaseDescribingAnnotation.java
@@ -7,7 +7,7 @@ public class BaseDescribingAnnotation extends AbstractAnnotation implements Desc
 
 	public BaseDescribingAnnotation(){
 		super();
-		setMotivation(MotivationTypes.DESCRIBING.getOaType());
+		motivation =MotivationTypes.DESCRIBING.getOaType();
 
 	} 
 

diff --git a/...ons/src/main/java/eu/europeana/annotation/definitions/model/impl/BaseImageAnnotation.java b/...ons/src/main/java/eu/europeana/annotation/definitions/model/impl/BaseImageAnnotation.java
@@ -7,7 +7,7 @@ public class BaseImageAnnotation extends AbstractAnnotation implements ImageAnno
 
 	public BaseImageAnnotation(){
 		super();
-		setMotivation(MotivationTypes.COMMENTING.getOaType());
+		motivation = MotivationTypes.COMMENTING.getOaType();
 
 	} 
 

diff --git a/...ava/eu/europeana/annotation/definitions/model/impl/BaseLinkForContributingAnnotation.java b/...ava/eu/europeana/annotation/definitions/model/impl/BaseLinkForContributingAnnotation.java
@@ -7,6 +7,6 @@ public class BaseLinkForContributingAnnotation extends AbstractAnnotation implem
 
 	public BaseLinkForContributingAnnotation(){
 		super();
-		setMotivation(MotivationTypes.LINKFORCONTRIBUTING.getOaType());
+		motivation = MotivationTypes.LINKFORCONTRIBUTING.getOaType();
 	}	
 }
diff --git a/...tions/src/main/java/eu/europeana/annotation/definitions/model/impl/BaseObjectLinking.java b/...tions/src/main/java/eu/europeana/annotation/definitions/model/impl/BaseObjectLinking.java
@@ -7,7 +7,7 @@ public class BaseObjectLinking extends AbstractAnnotation implements ObjectTag {
 
 	public BaseObjectLinking() {
 		super();
-		setMotivation(MotivationTypes.LINKING.getOaType());
+		motivation = MotivationTypes.LINKING.getOaType();
 	}
 
 }
diff --git a/...finitions/src/main/java/eu/europeana/annotation/definitions/model/impl/BaseObjectTag.java b/...finitions/src/main/java/eu/europeana/annotation/definitions/model/impl/BaseObjectTag.java
@@ -7,7 +7,7 @@ public class BaseObjectTag extends AbstractAnnotation implements ObjectTag {
 
 	public BaseObjectTag() {
 		super();
-		setMotivation(MotivationTypes.TAGGING.getOaType());
+		motivation = MotivationTypes.TAGGING.getOaType();
 	}
 
 }
diff --git a/.../src/main/java/eu/europeana/annotation/definitions/model/impl/BaseSubtitleAnnotation.java b/.../src/main/java/eu/europeana/annotation/definitions/model/impl/BaseSubtitleAnnotation.java
@@ -7,7 +7,7 @@ public class BaseSubtitleAnnotation extends AbstractAnnotation implements Annota
 
 	public BaseSubtitleAnnotation(){
 		super();
-		setMotivation(MotivationTypes.SUBTITLING.getOaType());
+		motivation = MotivationTypes.SUBTITLING.getOaType();
 
 	} 
 

diff --git a/...main/java/eu/europeana/annotation/definitions/model/impl/BaseTranscriptionAnnotation.java b/...main/java/eu/europeana/annotation/definitions/model/impl/BaseTranscriptionAnnotation.java
@@ -7,7 +7,7 @@ public class BaseTranscriptionAnnotation extends AbstractAnnotation implements T
 
 	public BaseTranscriptionAnnotation(){
 		super();
-		setMotivation(MotivationTypes.TRANSCRIBING.getOaType());
+		motivation = MotivationTypes.TRANSCRIBING.getOaType();
 
 	} 
 

diff --git a/...c/main/java/eu/europeana/annotation/definitions/model/impl/BaseTranslationAnnotation.java b/...c/main/java/eu/europeana/annotation/definitions/model/impl/BaseTranslationAnnotation.java
@@ -13,7 +13,7 @@ public class BaseTranslationAnnotation extends AbstractAnnotation implements Tra
    */
   public BaseTranslationAnnotation(){
 		super();
-		setMotivation(MotivationTypes.TRANSLATING.getOaType());
+		motivation = MotivationTypes.TRANSLATING.getOaType();
 	} 
 
 }