Skip to content

Commit

Permalink
Explicitly depend on fb_sysfs in fb_storage (#240)
Browse files Browse the repository at this point in the history
Summary:
I spun up a new class of GCE VM which uses NVMe-based storage, but fb_storage failed, complaining about being unable to find fb_sysfs. After digging into it a bit, I noticed that fb_storage doesn't explicitly depend on `fb_sysfs`, despite using it in several places, [like when configuring nvme-based storage](https://github.com/facebook/chef-cookbooks/blob/c64381a2e0195855703f59a001a64a589ae1ac73/cookbooks/fb_storage/resources/format_devices.rb#L169).

I verified that simply adding `depends 'fb_sysfs'` was enough to resolve the error.

Pull Request resolved: #240

Differential Revision: D60453758

fbshipit-source-id: 35e7b57bdecf37a1a27311004cd5cb66df70d1b6
  • Loading branch information
russtaylor authored and facebook-github-bot committed Jul 30, 2024
1 parent c64381a commit 27a816a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cookbooks/fb_storage/metadata.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@
version '0.0.1'
supports 'centos'
depends 'fb_helpers'
depends 'fb_sysfs'

0 comments on commit 27a816a

Please sign in to comment.