Skip to content

Commit

Permalink
Add proper support for USD on Artemis
Browse files Browse the repository at this point in the history
Summary:

Removed the actual bind mounts from this diff as boyuni's changes should be live by now.
Added a bunch of changes to make USD support better. Not perfect yet as the initial setup is still a bit problematic (the initial provisioning doesn't have the SMC tiers required to know that this should be using USD, therefore Tupperware bundle generation generates an `fbaccel` config, which breaks as soon as USD is activated):
* Added `fb-mtiautil-cli` as that's required to administer the card
* Added `fb-platform010-artemis-compiler` as that's required in the container but that RPM installs in the runtime and one cannot install that in the container. Long term this will be bundled into the binary
* Install `fb-asic-bootd` as that's USD
* Move the `asic_bootd` from the RPM into chef, 'cause babar prefers this, and it makes it easier to control start / stop / notifications upon changes. It's also easier to modify anything as one doesn't have to build, push and update the RPM
* Added a bunch of comments that `fb_grub` doesn't do anything on `twshared`, but all those changes have already been implemented where they are needed using host profiles
* Added the possibility to use two SMC tiers to control the deployment. As mentioned above, this isn't perfect, but we don't really have a better solution yet
* Taught Tupperware how to reset the card(s) before starting a container when in USD
* Rename `twshared_inference` to `twshared_t17` as we have inference on T16, TNG, even T20 and we always had it on T1 so this was misleading
* Added `asic_bootd` as an allowed WDB on T17
* Ensured the directories that Tupperware bindmounts exit. No longer bind-mount them ourselves as boyuni's changes to the agent should take care of that part
** To do that part, changed the systemd tmpclean recipe to actually run as soon as the file is modified, so the folders get created right before Tupperware tries to use them by validating the config.

Differential Revision: D51473619

fbshipit-source-id: 1fd749117df0a5f98f3180ec4b408999bceeb1f1
  • Loading branch information
Olivier Raginel authored and facebook-github-bot committed Dec 6, 2023
1 parent 83c704a commit 3b9741a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cookbooks/fb_systemd/recipes/default.rb
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
owner 'root'
group 'root'
mode '0644'
notifies :run, 'execute[process tmpfiles]'
notifies :run, 'execute[process tmpfiles]', :immediately
end

execute 'load modules' do
Expand Down

0 comments on commit 3b9741a

Please sign in to comment.