Skip to content

Commit

Permalink
Run NoOwnerGroupRoot on the entire codebase: github
Browse files Browse the repository at this point in the history
Summary:
Just run the previous diff on the rest of the code base to clean everything up. Only github showed something.

```
 $ hg show | grep '^[-+] ' | grep -vEe "^- *(owner|group) *'root'\$" -e  '^\+ *(owner|group) *node.root_(user|group)$'
```
So it literally just changes what it's supposed to.

Differential Revision: D56219068

fbshipit-source-id: 5084f44b47978ad885ff1a98cda9af7efbde3a56
  • Loading branch information
Olivier Raginel authored and facebook-github-bot committed May 28, 2024
1 parent 1b9ac4b commit a2eb99b
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 25 deletions.
20 changes: 10 additions & 10 deletions cookbooks/fb_fluentbit/recipes/fluent-bit_default.rb
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@
if node.windows?
rights :full_control, 'Administrators'
else
owner 'root'
group 'root'
owner node.root_user
group node.root_group
mode '0755'
end
end
Expand All @@ -82,8 +82,8 @@
rights :full_control, 'Administrators'
notifies :restart, 'windows_service[FluentBit]'
else
owner 'root'
group 'root'
owner node.root_user
group node.root_group
mode '0600'
notifies :restart, 'service[fluent-bit]'
end
Expand All @@ -97,8 +97,8 @@
rights :full_control, 'Administrators'
notifies :restart, 'windows_service[FluentBit]'
else
owner 'root'
group 'root'
owner node.root_user
group node.root_group
mode '0600'
notifies :restart, 'service[fluent-bit]'
end
Expand All @@ -113,8 +113,8 @@
rights :full_control, 'Administrators'
notifies :restart, 'windows_service[FluentBit]'
else
owner 'root'
group 'root'
owner node.root_user
group node.root_group
mode '0600'
notifies :restart, 'service[fluent-bit]'
end
Expand All @@ -129,8 +129,8 @@
rights :full_control, 'Administrators'
notifies :restart, 'windows_service[FluentBit]'
else
owner 'root'
group 'root'
owner node.root_user
group node.root_group
mode '0600'
notifies :restart, 'service[fluent-bit]'
end
Expand Down
20 changes: 10 additions & 10 deletions cookbooks/fb_fluentbit/recipes/td-agent-bit_default.rb
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@
if node.windows?
rights :full_control, 'Administrators'
else
owner 'root'
group 'root'
owner node.root_user
group node.root_group
mode '0755'
end
end
Expand All @@ -82,8 +82,8 @@
rights :full_control, 'Administrators'
notifies :restart, 'windows_service[FluentBit]'
else
owner 'root'
group 'root'
owner node.root_user
group node.root_group
mode '0600'
notifies :restart, 'service[td-agent-bit]'
end
Expand All @@ -97,8 +97,8 @@
rights :full_control, 'Administrators'
notifies :restart, 'windows_service[FluentBit]'
else
owner 'root'
group 'root'
owner node.root_user
group node.root_group
mode '0600'
notifies :restart, 'service[td-agent-bit]'
end
Expand All @@ -113,8 +113,8 @@
rights :full_control, 'Administrators'
notifies :restart, 'windows_service[FluentBit]'
else
owner 'root'
group 'root'
owner node.root_user
group node.root_group
mode '0600'
notifies :restart, 'service[td-agent-bit]'
end
Expand All @@ -129,8 +129,8 @@
rights :full_control, 'Administrators'
notifies :restart, 'windows_service[FluentBit]'
else
owner 'root'
group 'root'
owner node.root_user
group node.root_group
mode '0600'
notifies :restart, 'service[td-agent-bit]'
end
Expand Down
10 changes: 5 additions & 5 deletions cookbooks/fb_smokeping/recipes/default.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
directory '/var/run/smokeping' do
mode '0755'
owner 'smokeping'
group 'root'
group node.root_group
end

directory '/var/lib/smokeping' do
Expand All @@ -66,8 +66,8 @@

cookbook_file '/etc/smokeping/config' do
mode '0644'
owner 'root'
group 'root'
owner node.root_user
group node.root_group
end

directory '/etc/smokeping/config.d' do
Expand All @@ -89,8 +89,8 @@
template "/etc/smokeping/config.d/#{config}" do
source "#{config}.erb"
mode '0644'
owner 'root'
group 'root'
owner node.root_user
group node.root_group
notifies :restart, 'service[smokeping]'
end
end
Expand Down

0 comments on commit a2eb99b

Please sign in to comment.