feat: lazy timer commands #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, it was not possible to lazily declare an fb_timers entry that utilized a node attribute inside the command. After this commit, specifying a Proc for `command` or entries in `commands` will cause fb_timers to evaluate the proc when rendering the service template.
ericnorris
requested review from
jaymzh,
joshuamiller01 and
davide125
as code owners
jaymzh
approved these changes
Nov 8, 2024
|
Thanks @jaymzh! I think the |
|
yeah kitchen tests have been broken a while, and no one has had time to go fix them. @joshuamiller01 or @dafyddcrosby or someone will pull this in internally to run against extra internal tests and then merge if there's no issues. |
ericnorris
added a commit
to etsy/chef-cookbooks
that referenced
this pull request
Nov 11, 2024
Cherry-pick of facebook#242.
|
@dafyddcrosby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
Test Plan: Ran Chef, confirmed no timer changes seen Differential Revision: D65891069 fbshipit-source-id: 0ef9be602dc170682fd228c0e916a4038996fe28
|
Merged in 183ef44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, it was not possible to lazily declare an
fb_timersentry that utilized a node attribute inside the command.After this commit, specifying a
Procforcommandor entries incommandswill causefb_timersto evaluate the proc when rendering the service template.This is related to #233. I can't exactly recall where we landed on whether it was acceptable to add
Procsupport to cookbooks, but this particular example has come up enough times that I feel that it's worth enabling.(I couldn't run these tests locally, so I might need to iterate a bit if I made a mistake)