Fix fb_apache for Debian-family #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `verify_configs` custom resource wasn't using the passed-in httpdir and was assuming RHEL-like httpdir and config file name. Fixed both. Also, on Debian sid, the version-matching failed, so fixed that. Signed-off-by: Phil Dibowitz <phil@ipom.com>
|
@dafyddcrosby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
Test Plan: Confirmed no changes on CentOS: P1698345753 No Debian running in prod Differential Revision: D66515561 fbshipit-source-id: d859a941a881ad3c2c68dc9138400eaa2b7cc919
|
Not sure why this wasn't auto-closed, but this has now been merged 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
verify_configscustom resource wasn't using the passed-in httpdirand was assuming RHEL-like httpdir and config file name. Fixed both.
Also, on Debian sid, the version-matching failed, so fixed that.
Signed-off-by: Phil Dibowitz phil@ipom.com