Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added union method #200

Closed
wants to merge 4 commits into from
Closed

added union method #200

wants to merge 4 commits into from

Conversation

harsha-iiiv
Copy link

@harsha-iiiv harsha-iiiv commented May 18, 2019

Do the checklist before submitting the PR:

  • Have you read the guidelines mentioned in CONTRIBUTING.md?
  • Have you squashed your commits?

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0)
A: v10.15.0

Q: Mention the Issue Number! (e.g. Fixed #8)
A: #199 #192


@codecov-io
Copy link

codecov-io commented May 18, 2019

Codecov Report

Merging #200 into master will decrease coverage by 0.42%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage     100%   99.57%   -0.43%     
==========================================
  Files          79       81       +2     
  Lines        1411     1421      +10     
==========================================
+ Hits         1411     1415       +4     
- Misses          0        6       +6
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️
src/validation/any-type-ofarray.js 25% <25%> (ø)
src/union/index.js 40% <40%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd09333...7deba74. Read the comment docs.

Copy link
Owner

@fave77 fave77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harsha-iiiv you can claim one issue at a time and also provide unit tests while creating a new module

@fave77 fave77 closed this May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants