fix(core): Error downsampled query if lookback is short when querying rate/increase #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yu-shipit
reviewed
Nov 8, 2024
query/src/main/scala/filodb/query/exec/PeriodicSamplesMapper.scala
Outdated
Show resolved
Hide resolved
vishramachandran
force-pushed
the
downsample-lookback
branch
from
b67b88c to
71b0113
Compare
vishramachandran
changed the title
amolnayak311
requested changes
Nov 14, 2024
amolnayak311
previously approved these changes
Nov 14, 2024
amolnayak311
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Rate requires 2 samples in lookback window. Instead of returning empty result for rate in downsampled dataset (such queries with small window and smaller publish interval are encountered frequently in downsampled dataset),
we extend the lookback to two downsampled resolutionswe error the query out when lookback is insufficient. This fix is imperfect, but serves as a workaround until a better solution is delivered. Status quo affects customers by producing wrong query results and leads to thinking that there is data loss, or even worse, implicit trust that the query results are right.