feat(query): Adding support for optimizing raw metric to agg metric in HQE #1927
+324
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeep6189
reviewed
Jan 9, 2025
query/src/main/scala/filodb/query/util/HierarchicalQueryExperience.scala
Outdated
Show resolved
Hide resolved
query/src/main/scala/filodb/query/util/HierarchicalQueryExperience.scala
Outdated
Show resolved
Hide resolved
query/src/main/scala/filodb/query/util/HierarchicalQueryExperience.scala
Show resolved
Hide resolved
sandeep6189
reviewed
Jan 9, 2025
query/src/main/scala/filodb/query/util/HierarchicalQueryExperience.scala
Outdated
Show resolved
Hide resolved
query/src/main/scala/filodb/query/util/HierarchicalQueryExperience.scala
Show resolved
Hide resolved
query/src/main/scala/filodb/query/util/HierarchicalQueryExperience.scala
Outdated
Show resolved
Hide resolved
sandeep6189
force-pushed
the
handling-multiple-level-for-raw-queries
branch
from
7298097 to
8299436
Compare
sandeep6189
changed the title
sandeep6189
changed the title
sandeep6189
previously approved these changes
Jan 14, 2025
sandeep6189
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior :
Raw metric to Agg metric translation was not supported in HQE.
New behavior :
HQE is now supporting raw to agg metric translation if the aggregation rules constraint is satisfied and if
optimize_with_aggis used