Change margins to u8 to follow egui main #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with emilk/egui@249f8bc#diff-27a694b8b19044d8b902cbf26c497d371ee974d314ae11413cc10947b05a9f09 in egui upstream, rounding and margins are given in u8 whole points instead of f32. This breaks in exactly one position - inner margin in `file_dialog.rs` This PR fixes this, however this would then stop building on default egui 0.30. Thus this PR includes the same patch line in Cargo.toml that egui_plot is currently using (https://github.com/emilk/egui_plot/blob/80e2199a2e121db288fe6b0099d91c35acc75a7c/Cargo.toml#L43). Those need removal on or before the next egui/egui-file-dialog release.
|
Hey, thanks for the PR! I won't merge it until egui has built a new official version. So that we only use stable versions of egui here :) |
Thats fine, ill change the PR so that wont include the patch line then :) You might as well just keep this as a reminder and just fix it once egui updates, considering its two numbers that need changing^^ Thanks and have a good day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya!
Starting with
emilk/egui@249f8bc#diff-27a694b8b19044d8b902cbf26c497d371ee974d314ae11413cc10947b05a9f09
in egui upstream, rounding and margins are given in u8 whole points instead of f32.
This breaks in exactly one position - that one inner_margin call in
file_dialog.rsThis PR fixes this, however this would then stop building on default egui 0.30. Thus this PR includes the same patch line in Cargo.toml that egui_plot is currently using (https://github.com/emilk/egui_plot/blob/80e2199a2e121db288fe6b0099d91c35acc75a7c/Cargo.toml#L43). Those need removal on or before the next egui/egui-file-dialog release.