feat: update settings pages #927
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pavanjoshi914 could you please move the sidebar changes to a different PR? there seem to be some issues there especially since we can only show one sidebar card at a time. |
rolznz
reviewed
Jan 7, 2025
| {words.map((word, i) => { | ||
| const isRevealed = revealedIndex === i; |
There was a problem hiding this comment.
why was revealing the words removed?
|
@pavanjoshi914 when you do a PR like this can you please explain in the description more your thought process and considerations when making the changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sidebar card for update available
revamp settings screens
Fixes #924