Patrick/tamper

[garmr-ulfr]

I didn't implement tamper for UDP as we use solely TCP (as far as I know).

[Crosse]

Man, who thought it was a good idea to turn linting to 11?

checks notes, finds out it was me all along

Oh, yeah, that tracks. 🙄

[Crosse]

This is great! Thank you for buckling down and doing what I never seemed to have time to finish. This could absolutely be merged as-is as long as we ticketed a few of the outstanding items, but if we have the time and you wouldn't mind taking a look at the few comments I left and the things the linter found, I'd appreciate it.

[github-actions]

Pull Request Test Coverage Report for Build 6520555836

• 192 of 371 (51.75%) changed or added relevant lines in 5 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-3.6%) to 58.883%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
actions/fragment_packet.go	18	22	81.82%
actions/duplicate_action.go	1	7	14.29%
actions/tamper_action.go	138	307	44.95%

Files with Coverage Reduction	New Missed Lines	%
actions/tamper_action.go	2	44.29%

Totals
Change from base Build 3038527816:	-3.6%
Covered Lines:	822
Relevant Lines:	1396

---

💛 - Coveralls

[Crosse]

I haven't kept up with Go's recent changes to how it renders documentation (it can do Markdown now, right?), but I don't know that switching from spaces to a mix of tabs and spaces is useful, since it makes those lines highly dependent on how wide someone's tabs are. (Mine are always 8 spaces; VSCode uses four, etc.) I'd also like to remove the memory allocation/copy during checksum calculation, then this will be good to go.

[garmr-ulfr]

I haven't kept up with Go's recent changes to how it renders documentation (it can do Markdown now, right?)

What about Markdown?

but I don't know that switching from spaces to a mix of tabs and spaces is useful, since it makes those lines highly dependent on how wide someone's tabs are

Did tabs get inserted?? I just use the auto format. I did switch from gofmt to gofumpt though. I don't think that should have an affect on my editor. I'll have to check if I messed something up.