Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shared sensitive data library handling of snake_case variable names #18473

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Jan 10, 2025

Improve the share sensitive data library handling of snake_case variable names. This is especially relevant for Rust, where snake case is encouraged and widely used, but the main change is in the shared SensitiveDataHeuristics.qll file and will affect (hopefully benefit) other languages as well. It's a simple change, but we need a fairly high level of confidence / agreement before merging this.

Testing:

  • CI / tests passing (if you add up the sensitive data tests across all languages, coverage is really quite good)
  • review differences in sensitive data identified
    • Rust, all DCA projects (by running rust/summary/sensitive-data) --- experiment, 389 new sensitive expressions, LGTM
    • Swift, MRVA top-100 projects (by running swift/summary/sensitive-expressions) --- no differences
  • review differences in query results (DCA)
    • Javascript
    • Python
    • Ruby
    • Rust
    • Swift
  • check performance
    • swift/summary/sensitive-expressions (locally) --- no significant differences
    • swift/cleartext-logging (locally) --- no significant differences
    • DCA analysis times, all languages

@geoffw0 geoffw0 added Python Ruby Rust Pull requests that update Rust code Swift javascript Pull requests that update Javascript code labels Jan 10, 2025
@Copilot Copilot bot review requested due to automatic review settings January 10, 2025 14:49
@geoffw0 geoffw0 requested review from a team as code owners January 10, 2025 14:49

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation javascript Pull requests that update Javascript code JS Python Ruby Rust Pull requests that update Rust code Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant