Improve shared sensitive data library handling of snake_case variable names #18473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the share sensitive data library handling of
snake_case
variable names. This is especially relevant for Rust, where snake case is encouraged and widely used, but the main change is in the sharedSensitiveDataHeuristics.qll
file and will affect (hopefully benefit) other languages as well. It's a simple change, but we need a fairly high level of confidence / agreement before merging this.Testing:
rust/summary/sensitive-data
) --- experiment, 389 new sensitive expressions, LGTMswift/summary/sensitive-expressions
) --- no differencesswift/summary/sensitive-expressions
(locally) --- no significant differencesswift/cleartext-logging
(locally) --- no significant differences