Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing deployment and environment attributes #1187

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Add missing deployment and environment attributes #1187

merged 1 commit into from
Nov 28, 2024

Conversation

katrinSaleschus
Copy link
Contributor

No description provided.

jmini
jmini requested changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests should be added

src/main/java/org/gitlab4j/api/models/Environment.java Show resolved Hide resolved
src/main/java/org/gitlab4j/api/webhook/DeploymentEvent.java Show resolved Hide resolved
@katrinSaleschus katrinSaleschus marked this pull request as draft November 7, 2024 09:01
@katrinSaleschus katrinSaleschus force-pushed the addMissingDeploymentAndEnviormentAttributes branch from afdc6c7 to 4844253 Compare November 12, 2024 08:24
@katrinSaleschus katrinSaleschus marked this pull request as ready for review November 13, 2024 09:26
@katrinSaleschus
Copy link
Contributor Author

Thank you for your Review. Now everything should be ok to merge.

@jmini
Copy link
Collaborator

jmini commented Nov 18, 2024

I will have a look

@jmini jmini force-pushed the addMissingDeploymentAndEnviormentAttributes branch from c8456d1 to db5649a Compare November 28, 2024 19:23
@jmini
Copy link
Collaborator

jmini commented Nov 28, 2024

I have rebased the source branch of this PR (addMissingDeploymentAndEnviormentAttributes in your fork) on top of main of this repo:

git rebase --onto origin/main eb6603615878eb0f352f6984517e3aa653a0dd55
git push katrinSaleschus HEAD:addMissingDeploymentAndEnviormentAttributes --force

Be aware that your local branch addMissingDeploymentAndEnviormentAttributes has diverged with the one on the GitHub.

If you need to do one more changes on this branch:
I recommend to use git fetch and git reset --hard origin/addMissingDeploymentAndEnviormentAttributes (assuming your local origin is pointing to the katrinSaleschus fork on GitHub) before doing any local modifications instead of git pull.

I will change the target branch of this PR to be main

@jmini jmini changed the base branch from 6.x to main November 28, 2024 19:25
jmini
jmini approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you very much!

@jmini jmini merged commit 4c38074 into gitlab4j:main Nov 28, 2024
2 checks passed
@jmini jmini changed the title Add missing deployment and enviorment attributes Add missing deployment and environment attributes Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmini jmini jmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katrinSaleschus @jmini