Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add revokePersonalAccessToken(tokenId) and addSshKey expiresAt field #1195

Merged
merged 5 commits into from
Nov 28, 2024
Merged

add revokePersonalAccessToken(tokenId) and addSshKey expiresAt field #1195

merged 5 commits into from
Nov 28, 2024

Conversation

otary
Copy link
Contributor

@otary otary commented Nov 21, 2024

add revokePersonalAccessToken(tokenId) and addSshKey expiresAt field

jmini
jmini requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks (almost) good to me. Thank you.

And run ./gradlew :spotlessApply to apply the java formatter

@otary otary requested a review from jmini November 26, 2024 09:14
jmini
jmini requested changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have a look

src/main/java/org/gitlab4j/api/UserApi.java Outdated Show resolved Hide resolved
jmini
jmini approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the changes

@jmini jmini merged commit 1c22c25 into gitlab4j:main Nov 28, 2024
2 checks passed
@jmini jmini mentioned this pull request Nov 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmini jmini jmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otary @jmini