-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitLabApiForm in post requests #1224
Conversation
…String to, Object fromProjectId, boolean straight)
Can you elaborate what this fix is for? This might be a side effect of #1067 but I would like to understand what is wrong. Also I imagine other cases are affected as well. |
create project and update project errors using gitlab4j,i try to fix it |
Ok I did more testing, found some other cases, I have update the description and the title of this pull request. This is really good finding @otary 🎉 . Thank you a lot. |
A side effect of #1067 is that some methods no longer work, since they are not sending a
jakarta.ws.rs.core.Form
.Example when creating a group webhook:
Http trafic (see
Content-Type
header)When it should be:
Affected:
GroupApi.addGroup(..)
GroupApi.updateGroup(..)
GroupApi.addWebhook(..)
RepositoryApi.generateChangelog(..)
TopicsApi.createTopic(..)