Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing in threaded mode adding additional local-only emoji #2431

Conversation

Plastikmensch
Copy link

The case blocks are not scoped, so redeclaring variables doesn't work, so declare them outside and setting them as needed in case blocks.

@ClearlyClaire
Copy link

Ok I'm not sure about merging this, it's a bit of a mess, the eye is part of the post, and can be removed through editing (but that probably shouldn't be the case?)

The case blocks are not scoped, so redeclaring variables doesn't work, so declare them outside and setting them as needed in case blocks.

Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>
@Plastikmensch Plastikmensch force-pushed the fix-editing-in-threaded-mode-adding-additional-emoji branch from f219682 to 171dfde Compare October 28, 2023 03:42
@Plastikmensch
Copy link
Author

Plastikmensch commented Oct 28, 2023

Fixed Markdown being stripped when editing a Markdown formatted toot by using action.text instead of action.raw_text, which was undefined.

Ok I'm not sure about merging this, it's a bit of a mess, the eye is part of the post, and can be removed through editing (but that probably shouldn't be the case?)

It is indeed a bit of a mess and you are right, when sending a local-only toot the local-only emoji should be unconditionally added if the local-only option is set. That's why it needs to be removed. I have no idea why that doesn't happen when it's manually removed, but I though that was on purpose?

I should probably also mention that this PR builds on top of #2430

@Plastikmensch
Copy link
Author

Plastikmensch commented Oct 31, 2023

This is no longer needed as it's included in #2430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants