All internal uses of this.atEndOfInput() and this.atEndOfDocument() has been optimized (and justified), closing #20
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that some of these changes will be better exposed as API. Do not accept until I changed also that. :) |
fidel-ml
changed the title
this.atEndOfInput() and this.atEndOfDocument() has been optimized (and justified).this.atEndOfInput() and this.atEndOfDocument() has been optimized (and justified), closing #20
…nt() has been optimized fix #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: this PR MUST be done AFTER accepting the PR #18 (closing #17), as it is based on that branch.
The internal operations to implement
this.atEndOfInput()andthis.atEndOfDocument()were renamed for clarity, and then all uses of those operations were inlined and simplified, to avoid redundant calls and checks.All those changes were added as comments, justifying the changes step by step.