[Pdfr-43151] Fix failing tests for draupnir #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to upgrade dependencies but ran into test issues Tests were failing with: ``` 13 examples, 5 failures Failed examples: rspec ./spec/draupnir/instance_spec.rb:67 # /instances POST /instances creates the instance if given a ready image rspec ./spec/draupnir/instance_spec.rb:117 # /instances GET /instances returns a JSON payload showing the instance rspec ./spec/draupnir/instance_spec.rb:143 # /instances GET /instances/:id shows the given instance rspec ./spec/draupnir/instance_spec.rb:184 # /instances GET /instances/:id returns the correct credentials for a given instance rspec ./spec/draupnir/instance_spec.rb:208 # /instances DELETE /instances/:id deletes the instance and returns a 204 make: *** [Makefile:26: test-integration] Error 1 ``` When container is built it is running tests towards it, it fails to create instance with error: ``` time="2024-10-30T14:03:18Z" level=info msg="Creating instance" client_ip_address=192.168.127.1 environment=test error="exit status 1" .... error: connection to server at \"localhost\" (::1), port 17007 failed: FATAL: no pg_hba.conf entry for host \"::1\", user \"draupnir\", database \"postgres\", no encryption\n+ echo 'INFO: Not able to connect via non-TLS connection' ... nINFO: Not able to connect without client certificate\nStopping instance\nwaiting for server to shut down.... done\nserver stopped\n" ``` so therefore we are met with 500 error: `time="2024-10-30T14:03:18Z" level=info msg="POST /instances 500 0.790049" client_ip_address=192.168.127.1 duration=0.790048763 environment=test error="failed to create instance: exit status 1"` I modified current pg_hba.conf: ``` local all all trust hostssl all draupnir 0.0.0.0/0 cert map=draupnir ``` to ``` local all all trust hostssl all draupnir 127.0.0.1/32 cert map=draupnir hostssl all draupnir ::1/128 cert map=draupnir hostssl all draupnir 0.0.0.0/0 cert map=draupnir ``` With these changes: * We retain local trust for all users and dbs; * Added explicit localhost rule that will allows local connections, also from ipv6 on local podman setup. * All hostssl entries continue to use the cert auth with map=draupnir. and the result = `13 examples, 0 failures`
erungis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to upgrade dependencies but ran into test issues
Tests were failing with:
When container is built it is running tests towards it, it fails to create instance with error:
so therefore we are met with 500 error:
time="2024-10-30T14:03:18Z" level=info msg="POST /instances 500 0.790049" client_ip_address=192.168.127.1 duration=0.790048763 environment=test error="failed to create instance: exit status 1"I modified current pg_hba.conf:
to
With these changes:
and the result =
13 examples, 0 failures