Add configurable Stash timeout #2021
Open
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ullaakut
reviewed
Jan 15, 2025
| @@ -105,7 +105,7 @@ func addProxyRoutes( | |||
| if err != nil { | |||
| return err | |||
| } | |||
| st := stash.New(mf, s, indexer, stash.WithPool(c.GoGetWorkers), withSingleFlight) | |||
| st := stash.New(mf, s, indexer, c.TimeoutDuration(), stash.WithPool(c.GoGetWorkers), withSingleFlight) | |||
There was a problem hiding this comment.
If you are reusing the ATHENS_TIMEOUT variable, I'd suggest documenting that it now also serves this purpose.
Also, I don't know if there is a direct correlation between the timeout users might want to use for the VCS lister and for the stash. I'll let the others decide on whether it should be separate timeouts or not.
There was a problem hiding this comment.
Thanks for comment! Also want to mention, that stasher uses storage backend for uploading files, and for some providers (for example s3) it uses ATHENS_TIMEOUT as timeout for upload operations. It was a reason for reusing ATHENS_TIMEOUT instead of adding separete var, as for me it would be more clear behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Currently stash has hardcoded 10 minutes timeout which may leads to timeout errors.
How is the fix applied?
Add
timeoutfield tostasherfor using inStashcall. It's configurable viaATHENS_TIMEOUTvar.What GitHub issue(s) does this PR fix or close?
Fixes #1964
Fixes #1960