Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miss chinese translation of all section #2022

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

day253
Copy link
Contributor

@day253 day253 commented Jan 15, 2025

How is the fix applied?

Mention briefly how you have applied the fix.

Add miss chinese translation of all section

@day253 day253 requested a review from a team as a code owner January 15, 2025 12:02
Copy link
Collaborator

@Ullaakut Ullaakut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't attest to the quality of the translation, I assume it is AI-generated?
Content seems fine, snippets/commands are untouched (besides some comments). No code is changed, everything is correctly suffixed .zh.md. LGTM. Will let someone else take the decision on merging or not though.

@day253 day253 marked this pull request as draft January 15, 2025 13:16
@day253
Copy link
Contributor Author

day253 commented Jan 15, 2025

Can't attest to the quality of the translation, I assume it is AI-generated? Content seems fine, snippets/commands are untouched (besides some comments). No code is changed, everything is correctly suffixed .zh.md. LGTM. Will let someone else take the decision on merging or not though.

I apologize, but this is still in draft form and requires further revisions. The AI only helped me generate the basic structure, and I will carefully refine it later.

@Ullaakut
Copy link
Collaborator

Actually I just realized that there is only one other localized document in here, in Spanish, which seems not to have been updated in some time (6 years, against 9 months for the original English document) which leads me to wonder whether it's worth it to localize at all.

I'd say it's only worth it if you can guarantee that you or someone else will maintain the Chinese localization up-to-date with the English version to the best of your ability. If this is a one-time contribution, it is not worth it as it will only end up worsening the quality/reliability of the documentation over time.

Also I am not convinced that all of the markdown documents within the repository need localization. I would assume only the main ones need to. But I'll let others share their opinion on the matter.

@Ullaakut Ullaakut self-requested a review January 15, 2025 15:30
@day253
Copy link
Contributor Author

day253 commented Jan 15, 2025

I very much agree with your point. I also think that the maintenance cost is too high. In a project I participated in before, vcpkg has a complete and independent pipeline to solve this problem. The reason why I submitted this merge request is that if the language of this document page is switched, the complete directory structure cannot be seen even if there is still an English part. Nowadays, translation is so convenient, so it is better to only support English. Although I am willing to follow up and maintain this translation, I cannot track the submission of every document. Unless translation is a strict part of the document submission check, all languages need to be modified simultaneously for each modification. In addition, I found that the document links on this homepage are not completely #maintained. Some links are invalid, and the homepages in three languages are not synchronized. My more important need is to add more usage instructions in the document or wiki, so translation is not the core issue.

Actually I just realized that there is only one other localized document in here, in Spanish, which seems not to have been updated in some time (6 years, against 9 months for the original English document) which leads me to wonder whether it's worth it to localize at all.

I'd say it's only worth it if you can guarantee that you or someone else will maintain the Chinese localization up-to-date with the English version to the best of your ability. If this is a one-time contribution, it is not worth it as it will only end up worsening the quality/reliability of the documentation over time.

Also I am not convinced that all of the markdown documents within the repository need localization. I would assume only the main ones need to. But I'll let others share their opinion on the matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants