Remove dead code in package.py causing deployments to fail #4612
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanmetzman
approved these changes
Jan 15, 2025
vitorguidi
added a commit
that referenced
this pull request
Jan 15, 2025
This fixes the following error:
```
File "/usr/local/google/home/metzman/clusterfuzz-311/butler.py", line 421, in <module>
sys.exit(main())
^^^^^^
File "/usr/local/google/home/metzman/clusterfuzz-311/butler.py", line 407, in main
return command.execute(args)
^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/google/home/metzman/clusterfuzz-311/src/local/butler/deploy.py", line 576, in execute
package.package(
File "/usr/local/google/home/metzman/clusterfuzz-311/src/local/butler/package.py", line 87, in package
py_unittest.execute(args={})
File "/usr/local/google/home/metzman/clusterfuzz-311/src/local/butler/py_unittest.py", line 299, in execute
target=args.target,
^^^^^^^^^^^
AttributeError: 'dict' object has no attribute 'target'
```
vitorguidi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following error:
This happens to dead code in package.py that should have been deleted, the actual functionality lives in butler deploy.