Add regex to trim title's leading and trailing whitespaces, in comput…

…eUrl Sample usage: " pokemon " => "pokemon". Bump up to version 0.2.3
gorlandor · Sep 29, 2016 · 6f78474 · 6f78474
1 parent b9caa16
commit 6f78474
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/README.md b/README.md
@@ -5,8 +5,8 @@ A Polymer custom element that fetches movie, series, episode data from the
 
 # Change Log
 
-Version: 0.2.2
-- Remove redundant css properties
+Version: 0.2.3
+- Add regex to trim the title's leading and trailing whitespaces, in computeUrl
 
 
 # Demo it

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "omdb-search",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "authors": [
     "Giovanni Orlando Rivera <gorlandor@gmail.com>"
   ],

diff --git a/omdb-search.html b/omdb-search.html
@@ -190,15 +190,15 @@ <h4 class="result__heading">{{item.Title}}</h4>
                  * Specifies the movie, series, or episode title to query.
                  * Search value.
                  * Is required. */
-                q: {
+                 q: {
                     type: String,
                     value: 'Harry Potter',
                     notify: true
                 },
                 /**
                  * Search result type. Can be either movie, series, or episode.
                  * Is Optional. */
-                type: {
+                 type: {
                     type: String,
                     value: "movie",
                     notify: true
@@ -207,7 +207,7 @@ <h4 class="result__heading">{{item.Title}}</h4>
                  * Number representing the year in which the movie, series,
                  * or episode was released.
                  * Is optional. */
-                year: {
+                 year: {
                     type: Number,
                     value: '',
                     notify: true
@@ -216,7 +216,7 @@ <h4 class="result__heading">{{item.Title}}</h4>
                  * Specifies the data-interchange format to be used in ajax call.
                  * Can be either json, or xml.
                  * Is required. */
-                responseType: {
+                 responseType: {
                     type: String,
                     value: 'json',
                     notify: false
@@ -225,7 +225,7 @@ <h4 class="result__heading">{{item.Title}}</h4>
                  * Specifies the results-list page number,
                  * since OMDb pages search results (10 results per page).
                  * Is optional. */
-                page: {
+                 page: {
                     type: Number,
                     value: 1,
                     notify: true
@@ -234,15 +234,15 @@ <h4 class="result__heading">{{item.Title}}</h4>
                  * Specified the OMDb API version number, for future reference
                  * when said API updated.
                  * Is optional. */
-                apiVersion: {
+                 apiVersion: {
                     type: Number,
                     value: 1,
                     notify: false
                 },
                 /**
                  * Url computed from user assigned element props.
                  * Is required. */
-                url: {
+                 url: {
                     computed: 'computeUrl(q, type, year, responseType, page, apiVersion)'
                 },
                 /**
@@ -257,17 +257,17 @@ <h4 class="result__heading">{{item.Title}}</h4>
             /**
              * Computes and returns the request Url from the
              * user assigned element props. */
-            computeUrl: function(q, type, year, responseType, page, apiVersion) {
-                return `https://www.omdbapi.com/?s=${q}&type=${type}&y=${year}
+             computeUrl: function(q, type, year, responseType, page, apiVersion) {
+                return `https://www.omdbapi.com/?s=${ q.replace(/^\s+|\s+$/g, '') }&type=${type}&y=${year}
                 &r=${responseType}'&page=${page}&v=${apiVersion}`;
             },
             /**
              * Checks if the image source value received as input is valid,
              * otherwise returns empty string to default to the alt text. */
-            _computeImgSrc: function(src) {
+             _computeImgSrc: function(src) {
                 return (src === 'N/A')
-                    ? "../images/omdb-search.png"
-                    : src;
+                ? "../images/omdb-search.png"
+                : src;
             },
             /**
             * Used as the iron-ajax response handler function. */