mark actions as PENDING while executing #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwerner
changed the title
dwerner
force-pushed
the
action-execute-mark-pending
branch
from
9cdac0f to
ac636ef
Compare
fordN
reviewed
Jan 10, 2025
dwerner
force-pushed
the
action-execute-mark-pending
branch
from
ac636ef to
bcc74c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks actions as PENDING while they are being executed. Out of this we can remove the dependency on a long-lived database transaction that can time out and fail while execution may have succeeded.
This attempts to address a couple of issues that have shown up lately:
The behavior I've opted for here is: success and failures during execution result in the same behavior as before, however if there is an exception during execution, (such as from interacting with graph-node or from the contracts), then the Action is returned to APPROVED state and will be processed again on the next execution batch.
One edge case this introduces is that if the process were to be interrupted while Actions are marked PENDING, then those will be left in that state. A warning is issued to the operator that these will need to be examined and cleared manually.