fix: manage HTTP/1 to HTTP/2 requests #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcusnieux
force-pushed
the
6719-fix-http2
branch
from
2b96ca2 to
7f26f0a
Compare
brasseld
reviewed
Jun 27, 2022
gcusnieux
force-pushed
the
6719-fix-http2
branch
3 times, most recently
from
7aeb91f to
5f5904b
Compare
gcusnieux
force-pushed
the
6719-fix-http2
branch
from
5f5904b to
bff8187
Compare
gcusnieux
force-pushed
the
6719-fix-http2
branch
from
bff8187 to
0917a20
Compare
gcusnieux
force-pushed
the
6719-fix-http2
branch
from
0917a20 to
170075a
Compare
Comment on lines
+33
to
+45
| protected static final Set<CharSequence> HTTP2_ILLEGAL_HEADERS; | ||
|
|
||
| static { | ||
| HTTP2_ILLEGAL_HEADERS = | ||
| Set.of( | ||
| HttpHeaderNames.CONNECTION, | ||
| HttpHeaderNames.HOST, | ||
| HttpHeaderNames.PROXY_CONNECTION, | ||
| HttpHeaderNames.TRANSFER_ENCODING, | ||
| HttpHeaderNames.UPGRADE | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| protected static final Set<CharSequence> HTTP2_ILLEGAL_HEADERS; | |
| static { | |
| HTTP2_ILLEGAL_HEADERS = | |
| Set.of( | |
| HttpHeaderNames.CONNECTION, | |
| HttpHeaderNames.HOST, | |
| HttpHeaderNames.PROXY_CONNECTION, | |
| HttpHeaderNames.TRANSFER_ENCODING, | |
| HttpHeaderNames.UPGRADE | |
| ); | |
| } | |
| protected static final Set<CharSequence> HTTP2_ILLEGAL_HEADERS = | |
| Set.of( | |
| HttpHeaderNames.CONNECTION, | |
| HttpHeaderNames.HOST, | |
| HttpHeaderNames.PROXY_CONNECTION, | |
| HttpHeaderNames.TRANSFER_ENCODING, | |
| HttpHeaderNames.UPGRADE | |
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gravitee-io/issues#6719
Gravitee.io Automatic Deployment
🚀 A prerelease version of this package has been published on Gravitee's private artifactory, you can:
1.1.12-6719-fix-http2-SNAPSHOT