Improve Github skipping of duplicate runs

On GitHub unnecessary CPU/GPU test runs will be skipped (e.g. if only a toolchain file is modified).
This MR improves the handling of this in the following ways:
- Correct the syntax of `'paths'` (which defines which files require the CI to be run)
- Move the `if` from the job level to the step level so the job can be required for the PR

See merge request gysela-developpers/gyselalibxx!814

--------------------------------------------

.github/workflows/cpu_tests.yml

@@ -30,6 +30,11 @@ on:
         description: "The number of the pull request that triggered the test"
         required: false
         type: number
+      is_duplicate:
+        description: "Indicate if the run would be a duplicate"
+        required: false
+        default: false
+        type: boolean
 
 concurrency:
   group: ${{ github.event_name != 'workflow_dispatch' && format('{0}-{1}-{2}', github.workflow, inputs.pr_number, inputs.toolchain) || github.run_id }}
@@ -44,17 +49,21 @@ jobs:
     name: CPU Test (${{ inputs.toolchain }})
     steps:
       - name: Checkout gyselalibxx
+        if: ${{ (! inputs.is_duplicate) || true }}
         uses: actions/checkout@v4
         with:
           submodules: recursive
       - name: "Filter tests"
+        if: ${{ (! inputs.is_duplicate) || true }}
         uses: ./.github/actions/test_filter
         with:
           base_sha: ${{ inputs.merge_target }}
           trigger_type: ${{ github.event_name }}
       - name: Build code
+        if: ${{ (! inputs.is_duplicate) || true }}
         uses: ./.github/actions/build_code
         with:
           toolchain: toolchains/docker.gyselalibxx_env/${{ inputs.toolchain }}.cmake
       - name: Run tests
+        if: ${{ (! inputs.is_duplicate) || true }}
         uses: ./.github/actions/run_tests

.github/workflows/gpu_tests.yml

@@ -18,6 +18,11 @@ on:
         description: "The number of the pull request that triggered the test"
         required: false
         type: number
+      is_duplicate:
+        description: "Indicate if the run would be a duplicate"
+        required: false
+        default: false
+        type: boolean
 
 concurrency:
   group: ${{ github.event_name != 'workflow_dispatch' && format('{0}-{1}', github.workflow, inputs.pr_number) || github.run_id }}
@@ -29,21 +34,26 @@ jobs:
     environment: development
     steps:
       - name: Checkout gyselalibxx
+        if: ${{ (! inputs.is_duplicate) || true }}
         uses: actions/checkout@v4
         with:
           submodules: recursive
       - name: "Filter tests"
+        if: ${{ (! inputs.is_duplicate) || true }}
         uses: ./.github/actions/test_filter
         with:
           base: ${{ inputs.merge_target }}
           trigger_type: ${{ github.event_name }}
       - name: Setup environment
+        if: ${{ (! inputs.is_duplicate) || true }}
         run: |
           . toolchains/v100.persee/environment.sh
         shell: bash
       - name: Build code
+        if: ${{ (! inputs.is_duplicate) || true }}
         uses: ./.github/actions/build_code
         with:
           toolchain: toolchains/v100.persee/toolchain.cmake
       - name: Run tests
+        if: ${{ (! inputs.is_duplicate) || true }}
         uses: ./.github/actions/run_tests

.github/workflows/tests.yml

@@ -13,7 +13,7 @@ on:
 
 jobs:
   pre_job:
-    # continue-on-error: true # Uncomment once integration is finished
+    name: 'Check for unnecessary runs'
     runs-on: ubuntu-latest
     if: github.event.pull_request.draft == false
     # Map a step output to a job output
@@ -25,15 +25,7 @@ jobs:
         with:
           # All of these options are optional, so you can remove them if you are happy with the defaults
           skip_after_successful_duplicate: 'true'
-          paths:
-            - "src/**/*.hpp"
-            - "src/**/*.cpp"
-            - "tests/**/*.hpp"
-            - "tests/**/*.cpp"
-            - "simulations/**/*.hpp"
-            - "simulations/**/*.cpp"
-            - "**/CMakeLists.txt"
-            - "vendor/**"
+          paths: '["src/**/*.hpp", "src/**/*.cpp", "tests/**/*.hpp", "tests/**/*.cpp", "simulations/**/*.hpp", "simulations/**/*.cpp", "**/CMakeLists.txt", "vendor/**"]'
           cancel_others: 'false'
 
   cpu_tests:
@@ -43,21 +35,21 @@ jobs:
       fail-fast: false
     name: CPU Test (${{ matrix.toolchain }})
     needs: pre_job
-    if: needs.pre_job.outputs.should_skip != 'true' && github.event.pull_request.draft == false
     uses: ./.github/workflows/cpu_tests.yml
     with:
       toolchain: ${{ matrix.toolchain }}
       merge_target: ${{ github.event.pull_request.base.sha || github.event.merge_group.base_sha }}
       pr_number: ${{ github.event.pull_request.number }}
+      is_duplicate: ${{ needs.pre_job.outputs.should_skip != 'true' && github.event.pull_request.draft == false }}
 
   gpu_tests:
     name: GPU Test
     needs: pre_job
-    if: needs.pre_job.outputs.should_skip != 'true' && github.event.pull_request.draft == false
     uses: ./.github/workflows/gpu_tests.yml
     with:
       merge_target: ${{ github.event.pull_request.base.sha || github.event.merge_group.base_sha }}
       pr_number: ${{ github.event.pull_request.number }}
+      is_duplicate: ${{ needs.pre_job.outputs.should_skip != 'true' && github.event.pull_request.draft == false }}
 
   set_draft_failing:
     runs-on: ubuntu-latest