yet another try 3

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>

.github/workflows/pr-formatting.yaml

@@ -1,14 +1,35 @@
-name: PR Formatting Checks
-
+##
+# Copyright (C) 2023-2024 Hedera Hashgraph, LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+##
+name: "PR Formatting Checks"
 on:
   pull_request:
     types:
-      - opened
-      - edited
-      - labeled
-      - unlabeled
       - assigned
       - unassigned
+      - labeled
+      - unlabeled
+      - opened
+      - reopened
+      - edited
+      - converted_to_draft
+      - ready_for_review
+      - review_requested
+      - review_request_removed
+      - locked
+      - unlocked
       - synchronize
 
 defaults:
@@ -22,56 +43,72 @@ jobs:
   pr-formatting-checks:
     name: PR Formatting Checks
     runs-on: [self-hosted, Linux, medium, ephemeral]
-
     steps:
       - name: Check PR Title
-        uses: step-security/conventional-pr-title-action@v1.0.0
+        id: title-check
+        uses: step-security/conventional-pr-title-action@0eae74515f5a79f8773fa04142dd746df76666ac # v1.0.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         continue-on-error: true
-        id: check_title
-
-      - name: Set TITLE_CHECK_FAILED
-        if: ${{ steps.check_title.outcome != 'success' }}
-        run: echo "TITLE_CHECK_FAILED=true" >> $GITHUB_ENV
 
       - name: Check Milestone
-        if: ${{ github.event.pull_request.milestone == null }}
-        run: echo "MILESTONE_CHECK_FAILED=true" >> $GITHUB_ENV
+        id: milestone-check
+        run: |
+          if [[ "${{ github.event.pull_request.milestone }}" == "null" ]]; then
+            echo "Milestone is not set. Setting failure."
+            echo "MILESTONE_CHECK_FAILED=true" >> $GITHUB_ENV
+          fi
+        continue-on-error: true
 
       - name: Check Assignee
-        if: ${{ github.event.pull_request.assignees == '' }}
-        run: echo "ASSIGNEE_CHECK_FAILED=true" >> $GITHUB_ENV
+        id: assignee-check
+        run: |
+          if [[ "${{ github.event.pull_request.assignees }}" == "[]" ]]; then
+            echo "Assignee is not set. Setting failure."
+            echo "ASSIGNEE_CHECK_FAILED=true" >> $GITHUB_ENV
+          fi
+        continue-on-error: true
 
       - name: Check Labels
-        if: ${{ github.event.pull_request.labels == '' }}
-        run: echo "LABEL_CHECK_FAILED=true" >> $GITHUB_ENV
+        id: label-check
+        run: |
+          if [[ "${{ github.event.pull_request.labels }}" == "[]" ]]; then
+            echo "No labels are set. Setting failure."
+            echo "LABEL_CHECK_FAILED=true" >> $GITHUB_ENV
+          fi
+        continue-on-error: true
+
+      - name: Set Result for Title Check
+        if: steps.title-check.outcome == 'failure'
+        run: echo "TITLE_CHECK_FAILED=true" >> $GITHUB_ENV
 
       - name: Aggregate Results
         run: |
-          checks=(
-            "TITLE_CHECK_FAILED"
-            "MILESTONE_CHECK_FAILED"
-            "ASSIGNEE_CHECK_FAILED"
-            "LABEL_CHECK_FAILED"
-          )
-          check_titles=(
-            "Title Check"
-            "Milestone Check"
-            "Assignee Check"
-            "Label Check"
-          )
           failed=false
-
-          for i in "${!checks[@]}"; do
-            if [ "${{ env.${checks[$i]} }}" == "true" ]; then
-              echo "::error title=${check_titles[$i]}::❌ ${check_titles[$i]} failed"
-              failed=true
-            else
-              echo "::notice title=${check_titles[$i]}::✅ ${check_titles[$i]} passed"
-            fi
-          done
-
+          if [ "${{ env.TITLE_CHECK_FAILED }}" == "true" ]; then
+            echo "::error title=Title Check::❌ Title Check failed"
+            failed=true
+          else
+            echo "::notice title=Title Check::✅ Title Check passed"
+          fi
+          if [ "${{ env.MILESTONE_CHECK_FAILED }}" == "true" ]; then
+            echo "::error title=Milestone Check::❌ Milestone Check failed"
+            failed=true
+          else
+            echo "::notice title=Milestone Check::✅ Milestone Check passed"
+          fi
+          if [ "${{ env.ASSIGNEE_CHECK_FAILED }}" == "true" ]; then
+            echo "::error title=Assignee Check::❌ Assignee Check failed"
+            failed=true
+          else
+            echo "::notice title=Assignee Check::✅ Assignee Check passed"
+          fi
+          if [ "${{ env.LABEL_CHECK_FAILED }}" == "true" ]; then
+            echo "::error title=Label Check::❌ Label Check failed"
+            failed=true
+          else
+            echo "::notice title=Label Check::✅ Label Check passed"
+          fi
           if [ "$failed" == "true" ]; then
             exit 1
           fi