Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Get Block #26

Merged
merged 7 commits into from
Jul 29, 2024
Merged

feat: Added Get Block #26

merged 7 commits into from
Jul 29, 2024

Conversation

a-saksena
Copy link
Contributor

@a-saksena a-saksena commented Jun 20, 2024 •
edited
Loading

Description:

Related issue(s):

Fixes #25

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@a-saksena a-saksena self-assigned this Jun 20, 2024
@a-saksena a-saksena force-pushed the asaksena-25-get-block branch from 0491a7e to c48d618 Compare June 27, 2024 23:54
AlfredoG87
AlfredoG87 reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know is a WIP and still in draft, sorry if my comments are already or in the process of being changed.

You might want to do a rebase to include latest changes on the main branch.

protos/src/main/protobuf/blockstream.proto Outdated Show resolved Hide resolved
server/src/main/java/com/hedera/block/server/BlockStreamService.java Show resolved Hide resolved
@a-saksena a-saksena force-pushed the asaksena-25-get-block branch 2 times, most recently from 58d2a3f to eaec07d Compare July 24, 2024 00:04
@a-saksena a-saksena requested a review from AlfredoG87 July 24, 2024 00:08
AlfredoG87
AlfredoG87 requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaved a few nits

server/src/main/java/com/hedera/block/server/BlockStreamService.java Outdated Show resolved Hide resolved
server/src/main/java/com/hedera/block/server/BlockStreamService.java Outdated Show resolved Hide resolved
server/src/main/java/com/hedera/block/server/Server.java Outdated Show resolved Hide resolved
server/src/main/java/com/hedera/block/server/Server.java Outdated Show resolved Hide resolved
@a-saksena a-saksena marked this pull request as ready for review July 25, 2024 05:31
@a-saksena a-saksena requested review from a team as code owners July 25, 2024 05:31
AlfredoG87
AlfredoG87 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

a-saksena added 7 commits July 29, 2024 15:34
@a-saksena
Attempting to send a gRPC Status.NOT_FOUND on when the block does not…
9169c26 
… exist.

Signed-off-by: a-saksena <anurag@swirldslabs.com>
@a-saksena
Addressing issues with Builds and PR review comments.
a8100e2 
Signed-off-by: a-saksena <anurag@swirldslabs.com>
@a-saksena
Addressing Spotless styling issues.
dbdd4fd 
Signed-off-by: a-saksena <anurag@swirldslabs.com>
@a-saksena
Added jUnits. Changed the logic when the block is on found.
08a3dd1 
Signed-off-by: a-saksena <anurag@swirldslabs.com>
@a-saksena
Spotless Applied
9874c22 
Signed-off-by: a-saksena <anurag@swirldslabs.com>
@a-saksena
Corrected logger messages.
7c6664a 
Signed-off-by: a-saksena <anurag@swirldslabs.com>
@a-saksena
Fixing compilation errors.
042e9e9 
Signed-off-by: a-saksena <anurag@swirldslabs.com>
@a-saksena a-saksena force-pushed the asaksena-25-get-block branch from 311caae to 042e9e9 Compare July 29, 2024 22:34
@a-saksena a-saksena changed the title feature: Added Get Block feat: Added Get Block Jul 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 39.39394% with 20 lines in your changes missing coverage. Please review.

Project coverage is 54.33%. Comparing base (b5bebc5) to head (042e9e9).

Files Patch % Lines
.../src/main/java/com/hedera/block/server/Server.java 0.00% 16 Missing ⚠️
...va/com/hedera/block/server/BlockStreamService.java 76.47% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main      #26      +/-   ##
============================================
+ Coverage     50.99%   54.33%   +3.34%     
- Complexity       22       25       +3     
============================================
  Files             7        7              
  Lines           151      173      +22     
  Branches          5        6       +1     
============================================
+ Hits             77       94      +17     
- Misses           70       75       +5     
  Partials          4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-saksena a-saksena added New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. labels Jul 29, 2024
@a-saksena a-saksena added this to the 0.1.0 milestone Jul 29, 2024
@a-saksena a-saksena merged commit 691a4c1 into main Jul 29, 2024
7 of 9 checks passed
@a-saksena a-saksena deleted the asaksena-25-get-block branch July 29, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlfredoG87 AlfredoG87 AlfredoG87 approved these changes

@matteriben matteriben Awaiting requested review from matteriben matteriben was automatically assigned from hashgraph/release-engineering

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon jeromy-cannon is a code owner automatically assigned from hashgraph/release-engineering-managers

Assignees

@a-saksena a-saksena

Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Fetch a specific block (by block #)
2 participants
@a-saksena @AlfredoG87