Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update publishing workflow to use appropriate pre release and stable versions #2364

Conversation

rbarkerSL
Copy link
Contributor

Description:

Updates the publish_release workflow to accommodate the sdk, crypto, and proto release versions such that we can publish prerelease versions of subpackages that will not be marked as stable

Related issue(s):

Fixes #2363

proto/crypto subpackages

Need to look at validate tag and package versions to determine if there
are steps I need to take for comparison of the versions for the
subpackages as well

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarkerSL rbarkerSL requested review from a team as code owners June 25, 2024 18:11
@rbarkerSL rbarkerSL requested a review from tomzhenghedera June 25, 2024 18:11
@rbarkerSL rbarkerSL self-assigned this Jun 25, 2024
@rbarkerSL rbarkerSL added the github_actions Pull requests that update GitHub Actions code label Jun 25, 2024
@rbarkerSL rbarkerSL requested a review from nathanklick June 25, 2024 18:11
@rbarkerSL rbarkerSL added the bug Something isn't working label Jun 25, 2024
Copy link
Member

@nathanklick nathanklick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper dry-run guarding is needed.

.github/workflows/publish_release.yaml Show resolved Hide resolved
.github/workflows/publish_release.yaml Show resolved Hide resolved
.github/workflows/publish_release.yaml Show resolved Hide resolved
rbarkerSL added 12 commits June 25, 2024 13:31
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
subpackage

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Copy link

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (5c428d4) to head (b88d994).
Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2364      +/-   ##
==========================================
+ Coverage   76.49%   84.26%   +7.76%     
==========================================
  Files         304       53     -251     
  Lines       75800    11432   -64368     
==========================================
- Hits        57986     9633   -48353     
+ Misses      17814     1799   -16015     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Update publishing workflow to use appropriate pre-release and stable versions
2 participants