Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not reset receiverSignatureRequired in AccountUpdateTransaction by default #2450

Conversation

svetoslav-nikol0v
Copy link
Contributor

Description:

Do not reset receiverSignatureRequired field in AccountUpdateTransaction without being reset intentionally.

Fixes #2449

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Svet <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v svetoslav-nikol0v requested review from a team as code owners August 7, 2024 07:49
Copy link

sonarqubecloud bot commented Aug 7, 2024

@svetoslav-nikol0v svetoslav-nikol0v removed the request for review from rwalworth August 7, 2024 07:50
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylonikolov7 ivaylonikolov7 merged commit adcfd4c into main Aug 9, 2024
7 checks passed
@ivaylonikolov7 ivaylonikolov7 deleted the 2449-account-update-incorrectly-sets-the-receiver-signature-required-field branch August 9, 2024 10:37
This was referenced Aug 12, 2024
ivaylogarnev-limechain pushed a commit that referenced this pull request Aug 22, 2024
Signed-off-by: Svet <svetoslav.nikolov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account Update incorrectly sets the receiver signature required field
4 participants