Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use common Hiero Gradle config #302

Merged
merged 14 commits into from
Jan 13, 2025
Merged

Conversation

jjohannes
Copy link
Collaborator

@jjohannes jjohannes commented Oct 9, 2024

Description:

Before this can be integrated:

Related issue(s):

hashgraph/hedera-services#14255

@jjohannes jjohannes changed the title build: use plugins from 'hedera-gradle-conventions' build: use common Hedera Gradle config Oct 9, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 23f5995 to 8be0e9c Compare October 9, 2024 10:01
Copy link

github-actions bot commented Oct 9, 2024

JUnit Test Report

   67 files  ±0     67 suites  ±0   1m 58s ⏱️ -42s
1 265 tests ±0  1 262 ✅ ±0   3 💤 ±0  0 ❌ ±0 
7 120 runs  ±0  7 101 ✅ ±0  19 💤 ±0  0 ❌ ±0 

Results for commit 2b1a380. ± Comparison against base commit e0ab4f8.

This pull request removes 8 and adds 7 tests. Note that renamed tests count towards both.
, 1
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] FLOAT, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f5010311be0@3c346c45, [0.1, 0.5, 100.0], 12, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f5010311df8@16df9bde
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] STRING, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f501031ecf0@605eb072, [string 1, testing here, testing there], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f501031ef08@7a0f06ad
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] BYTES, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f501031f120@43fd77d8, [010203, ff7f0f, 42da07370bff], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f501031f338@5a90fcaa
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] DOUBLE, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f5010312010@2da5fdc, [0.1, 0.5, 100.0, 1.7653472635472653E240], 32, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f5010312228@23321be7
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [3] BOOL, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f5010312440@61ad30f6, [true, false, false, true, true, true], 6, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f5010312658@312f3050
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [4] ENUM, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f5010312870@615bad16, [Mock for EnumWithProtoMetadata, hashCode: 1290606579, Mock for EnumWithProtoMetadata, hashCode: 805976295, Mock for EnumWithProtoMetadata, hashCode: 1553616699], 3, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007f5010312a88@46894dc5
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] FLOAT, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc312298@37986daf, [0.1, 0.5, 100.0], 12, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc3124b0@c82d925
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [1] STRING, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc31f2c0@2dbf2da, [string 1, testing here, testing there], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc31f4d8@21a5b599
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] BYTES, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc31f6f0@7e38e254, [010203, ff7f0f, 42da07370bff], com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc31f908@7b3feb26
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [2] DOUBLE, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc3126c8@5432dca2, [0.1, 0.5, 100.0, 1.7653472635472653E240], 32, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc3128e0@12670e55
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [3] BOOL, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc312af8@43fd77d8, [true, false, false, true, true, true], 6, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc312d10@5a90fcaa
com.hedera.pbj.runtime.ProtoWriterToolsTest ‑ [4] ENUM, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc312f28@1805ec96, [Mock for EnumWithProtoMetadata, hashCode: 1479926346, Mock for EnumWithProtoMetadata, hashCode: 1457005276, Mock for EnumWithProtoMetadata, hashCode: 716724378], 3, com.hedera.pbj.runtime.ProtoWriterToolsTest$$Lambda/0x00007fd8cc313140@3fc1abf
com.hedera.pbj.runtime.Utf8ToolsTest ‑ [4] 
, 1

♻️ This comment has been updated with latest results.

@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 4 times, most recently from 0421a05 to 287af73 Compare October 11, 2024 07:05
@jjohannes jjohannes changed the title build: use common Hedera Gradle config build: use common Hiero Gradle config Nov 4, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 287af73 to 66309f0 Compare December 19, 2024 09:17
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from ffeefe6 to e6fd5d9 Compare January 9, 2025 09:36
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from e6fd5d9 to 58f0a22 Compare January 9, 2025 09:40
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
@jjohannes jjohannes marked this pull request as ready for review January 9, 2025 12:46
@jjohannes jjohannes requested a review from a team as a code owner January 9, 2025 12:46
Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not an expert in Gradle or GitHub scripts, the modifications look reasonable to me. But it would be great to have an expert review those changes as well.

Java code changes look great. Approved.

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
mishomihov00
mishomihov00 previously approved these changes Jan 10, 2025
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to:
.github/dependabot.yml
.github/workflows/flow-deploy-release-artifact.yaml
.github/workflows/zxc-compile-pbj-code.yaml

Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
mishomihov00
mishomihov00 previously approved these changes Jan 13, 2025
@jjohannes
Copy link
Collaborator Author

Had to resolve conflicts caused by #348 (nothing changed in this PR)

Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjohannes jjohannes merged commit 2fbee2b into main Jan 13, 2025
9 checks passed
@jjohannes jjohannes deleted the 14255-reusable-gradle-config branch January 13, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants