-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use common Hiero Gradle config #302
Conversation
23f5995
to
8be0e9c
Compare
JUnit Test Report 67 files ±0 67 suites ±0 1m 58s ⏱️ -42s Results for commit 2b1a380. ± Comparison against base commit e0ab4f8. This pull request removes 8 and adds 7 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
0421a05
to
287af73
Compare
287af73
to
66309f0
Compare
00bfb81
to
ffeefe6
Compare
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
ffeefe6
to
e6fd5d9
Compare
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
e6fd5d9
to
58f0a22
Compare
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/PbjCompilerTask.java
Show resolved
Hide resolved
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I'm not an expert in Gradle or GitHub scripts, the modifications look reasonable to me. But it would be great to have an expert review those changes as well.
Java code changes look great. Approved.
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/PbjCompiler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review applies to:
.github/dependabot.yml
.github/workflows/flow-deploy-release-artifact.yaml
.github/workflows/zxc-compile-pbj-code.yaml
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
2b1a380
Had to resolve conflicts caused by #348 (nothing changed in this PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Before this can be integrated:
Related issue(s):
hashgraph/hedera-services#14255