Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missing ibexa/notifications dev dependency #62

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fixed missing ibexa/notifications dev dependency #62

merged 1 commit into from
Apr 11, 2024

Conversation

konradoboza
Copy link
Contributor

🎫 Issue -

Description:

For QA:

Documentation:

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza requested a review from a team April 11, 2024 07:45
@konradoboza konradoboza requested a review from a team April 11, 2024 07:47
Steveb-p
Steveb-p approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not needed for 4.6?

@Steveb-p Steveb-p requested a review from a team April 11, 2024 07:48
@konradoboza
Copy link
Contributor Author

It's not needed for 4.6?

Strangely it fails only on main, ref: 52efc46.

@konradoboza konradoboza merged commit 920fff0 into main Apr 11, 2024
10 checks passed
@konradoboza konradoboza deleted the added-missing-dependency branch April 11, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@ciastektk ciastektk ciastektk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@webhdx webhdx

@tischsoic tischsoic

@konradoboza konradoboza

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@konradoboza @Steveb-p @ciastektk @ViniTou @webhdx @tischsoic