Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

898 save app state version 3 #1105

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

898 save app state version 3 #1105

wants to merge 31 commits into from

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Mar 15, 2024

Companion to insightsengineering/teal#1011
Replaces uses of update*Input with server-side input creation with renderUI.

@chlebowa chlebowa marked this pull request as ready for review March 15, 2024 15:08
Copy link
Contributor

github-actions bot commented Mar 15, 2024

Unit Tests Summary

  1 files   33 suites   2s ⏱️
150 tests 150 ✅   0 💤 0 ❌
282 runs  170 ✅ 112 💤 0 ❌

Results for commit 19cca0a.

♻️ This comment has been updated with latest results.

@gogonzo
Copy link
Contributor

gogonzo commented May 8, 2024

@donyunardi this one is paused as I noticed some restore issues - specifically "teal_bookmarkable" was not properly set for some modules (I don't remember which now), but it looked serious for me back then in March

@donyunardi donyunardi marked this pull request as draft May 13, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants