ui: fix banners overlapping #2947
Conversation
| &.manage { | ||
| padding: 1em 0; | ||
| } | ||
| &.record-banner { |
There was a problem hiding this comment.
why is a new class needed? can't we apply this to the flashed message directly?
There was a problem hiding this comment.
also, shouldn't it be in invenio-theme?
There was a problem hiding this comment.
This will affect the main banner as well and cause this:
There was a problem hiding this comment.
sorry, it took me some time to understand the implications.
if I managed to understand correctly, the fix will work only for the record detail page, what if we have the banner in other pages? f.e. community form has an error?
if that is the case, could you propose a solution which is more generic and works for all cases, not only for a record?
anikachurilova
force-pushed
the
fix-banners-css
branch
from
c7ad332 to
9ce4b61
Compare
| @@ -104,7 +104,7 @@ | |||
|
|
|||
| <!-- PREVIEW HEADER --> | |||
| {% if is_preview %} | |||
| <div class="ui info flashed bottom attached manage message"> | |||
| <div class="ui info flashed bottom attached manage message record-banner"> | |||
There was a problem hiding this comment.
since you moved the css to invenio theme, you should also propagate the template changes to the invenio-theme templates, otherwise it will be fixed only here in the record details template of app rdm
Closes: CERNDocumentServer/cds-rdm#296
Page banner:
"Newer version" record banner:
Error record banner:
"Preview" record banner
