views: optional index page registration #2952
Conversation
kpsherva
commented
Jan 8, 2025
kpsherva
commented
- closes Homepage: rework to show current communities CERNDocumentServer/cds-rdm#204
kpsherva
force-pushed
the
theme-view
branch
2 times, most recently
from
ab347a7 to
c54e335
Compare
invenio_app_rdm/theme/views.py
Outdated
| @@ -43,8 +43,10 @@ def create_blueprint(app): | |||
| template_folder="templates", | |||
| static_folder="static", | |||
| ) | |||
|
|
|||
| blueprint.add_url_rule(**create_url_rule(routes["index"], default_view_func=index)) | |||
| if app.config["RDM_FRONTPAGE"]: | |||
There was a problem hiding this comment.
may i ask what the use case is to make the / route optional?
what will be rendered then as default if it is not configured?
There was a problem hiding this comment.
I would like to have custom view context, see
https://github.com/CERNDocumentServer/cds-rdm/pull/311/files#diff-1a67a7df3625c50413611bb5279e5be98b8b9b870aff748a0dde81062a0e3ceb
There was a problem hiding this comment.
For what it's worth, I've left a comment on the CDS PR, suggesting a different approach for overriding views.
I can add this approach to docs, unless, we want to find a better approach so we're not limiting ourselves in the current 2-tuple format for the route values.
| return window.MathJax?.typeset(); | ||
| } | ||
| }; | ||
| if (document.body.dataset.invenioConfig) { |
There was a problem hiding this comment.
This should always be there. @anikachurilova worked on this.
What was the issue?
|
I fail to understand what this PR is changing. Do you mind adding a very brief explanation? |
