refactor: modified the ios_config script to use single quotes instead… #604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of backslashes
Description
A recent change to ios_config.sh introduced a line with backslashes. Backslashes are known to cause issues with React-Native-Version. See stovmascript/react-native-version#327. This is because of a known issue with pbxproj-dom NativeScript/pbxproj-dom#9. It does not appear that this issue is going to be addressed in those projects. My proposed solution is switching from a backslash to single quotes around the special character (https://linuxsimply.com/bash-scripting-tutorial/string/basics/escape-string/). This is a refactor where no behavior changed.
I created a patch to accomplish this in my project, but I thought since it might be affecting others, I would submit a PR.
Related issues
Release Summary
swapped from backslashes to single quotes to play nice with react-native-version
Checklist
and followed the process outlined there for submitting PRs.
Android
iOS
e2e
tests added or updated in__tests__e2e__
jest
tests added or updated in__tests__
Test Plan
Think
react-native-google-mobile-ads
is great? Please consider supporting the project with any of the below:Invertase
on Twitter🔥