Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: modified the ios_config script to use single quotes instead… #604

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

ccorneliusHsv
Copy link
Contributor

@ccorneliusHsv ccorneliusHsv commented Jul 10, 2024

… of backslashes

Description

A recent change to ios_config.sh introduced a line with backslashes. Backslashes are known to cause issues with React-Native-Version. See stovmascript/react-native-version#327. This is because of a known issue with pbxproj-dom NativeScript/pbxproj-dom#9. It does not appear that this issue is going to be addressed in those projects. My proposed solution is switching from a backslash to single quotes around the special character (https://linuxsimply.com/bash-scripting-tutorial/string/basics/escape-string/). This is a refactor where no behavior changed.

I created a patch to accomplish this in my project, but I thought since it might be affecting others, I would submit a PR.

Related issues

Release Summary

swapped from backslashes to single quotes to play nice with react-native-version

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter
    🔥

@ccorneliusHsv ccorneliusHsv marked this pull request as ready for review July 10, 2024 15:58
@dylancom
Copy link
Collaborator

Hi, thanks for the PR. But I think a patch is sufficient in this case supporting a library that had it's last release in march 2020.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno, I can't promise we won't accidentally break it again as there's no testing around the case, but it's kind of a neat shell scripting trick, I'm okay with it though yes @dylancom it's a bit cheese to be doing a workaround for a transitive transitive that's out of date 😆 .

I read the bash link you included (thank you) and it was good to have a refresher on that anyway, so I'm +1 on this tiny patch as it forced me to refresh some knowledge that was fading anyway 🤷 works for me

@mikehardy mikehardy requested a review from dylancom July 13, 2024 03:51
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.66%. Comparing base (a34c7ba) to head (44daab0).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
- Coverage   43.72%   42.66%   -1.06%     
==========================================
  Files          30       31       +1     
  Lines         549      565      +16     
  Branches      151      154       +3     
==========================================
+ Hits          240      241       +1     
- Misses        309      324      +15     

@dylancom dylancom merged commit c9e2ca7 into invertase:main Jul 13, 2024
12 of 13 checks passed
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 14.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants