Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Dark theme #442

Open
wants to merge 26 commits into
base: staging
Choose a base branch
from

Conversation

KaiserBarbarossa
Copy link
Member

@KaiserBarbarossa KaiserBarbarossa commented Jan 22, 2021

Just a WIP pull request.

The dark theme would just be created if the user has enabled dark theme in his/her operating system.

@chris34
Copy link
Member

chris34 commented Jan 23, 2021

  • I would suggest to use css properties to avoid c&p of many css selectors (that will probably cause problems in the future). I have an demo HTML attached, that demonstrates what i mean (the example uses just the browser-width to change the color of the heading).
  • Another problem will be wrong/low-contrast color of icons. Personally i would try to avoid multiple icon-files with just different color. https://css-tricks.com/change-color-of-svg-on-hover/ lists some ways for SVGs. I'm still unsure, whether <svg><use>…, filter:, mask: instead of backound-image or inlining SVG in CSS fits best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants