Refactor updateArticle function and fix conditional in webhookProduct…

…Update

 • Extract article data construction into a separate object for clarity in updateArticle.
 • Ensure image URLs are stripped of query parameters before updating in updateArticle.
 • Add a check for shopifyProduct.id in the conditional of webhookProductUpdate to prevent processing without a product ID.

src/functions/customer/orchestrations/customer/update/update-article.ts

@@ -61,26 +61,30 @@ export const updateArticle = async ({
     tags.push(`gender-${user.gender}`);
   }
 
+  const data = {
+    article: {
+      id: user.articleId,
+      body_html: user.aboutMeHtml,
+      tags: tags.join(", "),
+      summary_html: user.shortDescription,
+      ...(user.images?.profile?.url
+        ? {
+            image: {
+              src: user.images?.profile.url.includes("?")
+                ? user.images?.profile.url.split("?")[0]
+                : user.images?.profile.url,
+              alt: user.username,
+            },
+          }
+        : {}),
+      published_at: user.active ? user.createdAt : null,
+    },
+  };
+
   const response = await shopifyRest().put(
     `blogs/105364226375/articles/${user.articleId}`,
     {
-      data: {
-        article: {
-          id: user.articleId,
-          body_html: user.aboutMeHtml,
-          tags: tags.join(", "),
-          summary_html: user.shortDescription,
-          ...(user.images?.profile
-            ? {
-                image: {
-                  src: user.images?.profile.url,
-                  alt: user.username,
-                },
-              }
-            : {}),
-          published_at: user.active ? user.createdAt : null,
-        },
-      },
+      data,
     }
   );
 

src/functions/webook-product.function.ts

@@ -76,7 +76,7 @@ app.http("webhookProductUpdate", {
       const regex = /userid-(\d+)/;
       const match = shopifyProduct.tags.match(regex);
 
-      if (match && shouldProcessUpdate) {
+      if (match && shouldProcessUpdate && shopifyProduct.id) {
         // The user ID is in the first capturing group
         const customerId = match[1];
         console.log(`User ID: ${customerId}, - ${shopifyProduct.id}`);