Remove customer profile fields from creation schema and service

[jamalsoueidan]

PR Type

Enhancement, Bug fix

---

Description

• Removed professions, aboutMe, aboutMeHtml, and shortDescription fields from the customer creation schema and service.
• Made username field required in the user schema.
• Added username field to the user creation in the test setup.
• Fixed import formatting for GenerateAvailabilityProps in the test file.

---

Changes walkthrough 📝

	Relevant files
Enhancement	create.ts Simplify customer creation schema by removing profile fields src/functions/customer/controllers/customer/create.ts Removed professions, aboutMe, aboutMeHtml, and shortDescription fields from the customer creation schema. +0/-4      create.ts Update customer service creation body type                              src/functions/customer/services/customer/create.ts Updated CustomerServiceCreateBody type to exclude professions, aboutMe, aboutMeHtml, and shortDescription fields. +1/-9
Bug fix	user.schema.ts Set username field as required in user schema                        src/functions/user/user.schema.ts Made username field required in the user schema. +1/-1
Tests	generate-availability.spec.ts Add username field in test setup and fix import formatting src/library/availability/generate-availability.spec.ts Added username field to the user creation in the test setup. Fixed import formatting for GenerateAvailabilityProps. +2/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]	2
🧪 Relevant tests	No
🔒 Security concerns	No
⚡ Key issues to review	Possible Bug: The removal of fields such as professions, aboutMe, aboutMeHtml, and shortDescription from the customer creation schema and service might impact other parts of the application that rely on these fields. Ensure that these changes do not break existing functionalities.
	Data Validation: The username field in the user schema is now required. Ensure that all existing and new code paths that create users handle this requirement correctly to avoid runtime errors.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Performance	Reinstate the index property on the 'username' field for consistent indexing and performance Ensure that the 'username' field is consistently indexed across your schema definitions. If 'username' should be unique and indexed, it might be beneficial to maintain the 'index: true' property for consistency and performance, especially if queries on this field are frequent. src/functions/user/user.schema.ts [43-46] username: { type: String, unique: true, + index: true, required: true, }, Suggestion importance[1-10]: 9 Why: Maintaining the 'index: true' property for the 'username' field ensures consistent indexing and can improve query performance, which is beneficial for frequently queried fields.	9
Enhancement	Add validation for the 'speaks' field in the customer creation schema Consider validating the presence of the 'speaks' field in the schema since it is included in the customer creation schema. This ensures that all necessary data is validated and consistent with the schema requirements. src/functions/customer/controllers/customer/create.ts [15-19] customerId: true, fullname: true, username: true, gender: true, -speaks: true, +speaks: { required: true }, Suggestion importance[1-10]: 8 Why: Adding validation for the 'speaks' field ensures that all necessary data is validated and consistent with the schema requirements, which is important for data integrity.	8
	Add a test case for handling the 'username' field in the 'generateAvailability' function Add a test case to verify the behavior of the 'generateAvailability' function when the 'username' field is provided, as this field is now being included in the user model creation within tests. src/library/availability/generate-availability.spec.ts [102-106] UserModel.create({ customerId, fullname: "jamal soueidan", username: "jamal", }) +// Add test case here to verify 'username' handling Suggestion importance[1-10]: 6 Why: Adding a test case to verify the behavior of the 'generateAvailability' function when the 'username' field is provided ensures that the new field is properly handled, improving test coverage and reliability.	6
Possible issue	Update business logic and validations related to removed fields in the customer creation service Since fields like 'professions', 'aboutMe', and 'shortDescription' have been removed from the customer creation service, ensure that any business logic or validations that previously depended on these fields are also updated or removed to prevent runtime errors. src/functions/customer/services/customer/create.ts [3-5] export type CustomerServiceCreateBody = Pick< User, "customerId" | "fullname" | "username" | "gender" | "speaks" >; +// Ensure related business logic is updated accordingly Suggestion importance[1-10]: 7 Why: Ensuring that any business logic or validations that previously depended on the removed fields are updated or removed helps prevent potential runtime errors, maintaining the robustness of the service.	7