Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Twitter support #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

artdude543
Copy link
Contributor

  • Now, this is not really ideal as we're now using another OAuth lib. But it does open some more doors for interfacing with other API's.
  • The main issue with Twitter and you'll see the hack in the code is the transferring of the state query. So it's allowed to be given the end handler. There could be other ways of handling it but this worked for the usage case for now.
    • I'm removing the key store in error handling. But I may be missing some cases.

But this adds much-needed support for me and avoids having to use another lib hander. Suggestions welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant