Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY ProfileDialog a bit #25

Merged
merged 4 commits into from
Oct 13, 2024
Merged

DRY ProfileDialog a bit #25

merged 4 commits into from
Oct 13, 2024

Conversation

januschung
Copy link
Owner

@januschung januschung commented Oct 13, 2024 •
edited
Loading

  • extract the profile textfield to a reusable component to DRY thing a bit
  • group all the fields into an array to make thing in a configurable way instead of typing out the fields repeatedly
  • group various useState fields into a single useState array
  • remove old ProfileForm.jsx and the test that had never been called due to a bad PR submission.

oseasmoran73
oseasmoran73 approved these changes Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@oseasmoran73 oseasmoran73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clean! I like it 🚀

@januschung januschung merged commit 6c8245e into main Oct 13, 2024
1 check passed
@januschung januschung deleted the dry-thing-up branch October 13, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseasmoran73 oseasmoran73 oseasmoran73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@januschung @oseasmoran73