Override global option with group option #822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local options override globally set options, but options set on the `every` group do not. It makes sense for the options defined closer to the actual job to override those set further away, so we change the merge order of options to allow options passed to `every` to override those set globally with `set`. We still allow local options set on each job to override those set on the group.
njakobsen
force-pushed
the
override-global-option-with-group-option
branch
from
7ecda7f to
6e62bb9
Compare
|
@javan was there anything else you'd like me to add before considering this patch? |
|
Or rather, @benlangfeld, it seems you're the most active maintainer; does this PR pass muster? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local options override globally set options, but options set on the
everygroup do not.It makes sense for the options defined closer to the actual job to override those set further away, so we change the merge order of options to allow options passed to
everyto override those set globally withset. We still allow local options set on each job to override those set on the group.